All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: Jon Mason <jon.mason@exar.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"bhutchings@solarflare.com" <bhutchings@solarflare.com>,
	Ramkrishna Vepa <Ramkrishna.Vepa@exar.com>,
	"sgruszka@redhat.com" <sgruszka@redhat.com>,
	"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [Patch 1/2] s2io: remove lro parameter
Date: Fri, 20 Aug 2010 16:54:04 +0800	[thread overview]
Message-ID: <4C6E42AC.4070401@redhat.com> (raw)
In-Reply-To: <20100818153626.GC9202@exar.com>

On 08/18/10 23:36, Jon Mason wrote:
> On Wed, Aug 18, 2010 at 12:51:09AM -0700, Amerigo Wang wrote:
>>
>> As suggested by David, this parameter can die, we can use ethtool
>> to turn LRO on/off. Compile tests only.
>
> Needs some additional removal
>
> Line 41 and 42 " * lro: Specifies whether to enable Large Receive ..."
> As you have removed the modparm
>
> Line 8286 "if (sp->lro)"
> As it will always be on in this instance
>
>
> Also, all references to "sp->lro" can be converted to "(dev->features
> &  NETIF_F_LRO)", removing an unnecessary variable.
>

Thanks for pointing these out.
I will fix them later.

-- 
The opposite of love is not hate, it's indifference.
  - Elie Wiesel

  reply	other threads:[~2010-08-20  8:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-18  7:51 [Patch 1/2] s2io: remove lro parameter Amerigo Wang
2010-08-18  7:51 ` [Patch 2/2] mlx4: remove num_lro parameter Amerigo Wang
2010-08-23  4:45   ` David Miller
2010-08-18 15:36 ` [Patch 1/2] s2io: remove lro parameter Jon Mason
2010-08-20  8:54   ` Cong Wang [this message]
2010-08-23  8:42     ` Cong Wang
2010-08-23 15:41       ` Jon Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C6E42AC.4070401@redhat.com \
    --to=amwang@redhat.com \
    --cc=Ramkrishna.Vepa@exar.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=jon.mason@exar.com \
    --cc=netdev@vger.kernel.org \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.