From: Paolo Bonzini <pbonzini@redhat.com>
To: Wei Yongjun <yjwei@cn.fujitsu.com>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH v2] KVM: x86 emulator: add LDS/LES/LFS/LGS/LSS instruction emulation
Date: Fri, 20 Aug 2010 11:09:12 +0200 [thread overview]
Message-ID: <4C6E4638.7070507@redhat.com> (raw)
In-Reply-To: <4C6DF3CA.80709@cn.fujitsu.com>
On 08/20/2010 05:17 AM, Wei Yongjun wrote:
> Add LDS/LES/LFS/LGS/LSS instruction emulation.
> (opcode 0xc4, 0xc5, 0x0f 0xb2, 0x0f 0xb4~0xb5)
>
> Signed-off-by: Wei Yongjun<yjwei@cn.fujitsu.com>
> ---
> v1 -> v2: mask LES/LDS as No64.
The whole "case SrcMemFAddr" should refuse a register operand, so that
"JMP FAR PTR reg" (0xff 0xeb for example) and "LDS reg, reg" (0xc4
0xc3), would raise a #UD. I'm pretty sure it is handled incorrectly
right now, and I'm wondering if the resulting access to
ctxt->decode->src.valptr would allow a small information leak from the
kernel...
This bug is preexisting however, so I think it can be done as a
follow-up patch.
Thanks!
Paolo
next prev parent reply other threads:[~2010-08-20 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 9:03 [PATCH] KVM: x86 emulator: add LDS/LES/LFS/LGS/LSS instruction emulation Wei Yongjun
2010-08-20 3:17 ` [PATCH v2] " Wei Yongjun
2010-08-20 9:09 ` Paolo Bonzini [this message]
2010-08-22 9:54 ` Avi Kivity
2010-08-23 6:47 ` [PATCH] Add realmode test for LDS/LES/LFS/LGS/LSS instruction Wei Yongjun
2010-08-23 23:18 ` Marcelo Tosatti
2010-08-23 6:56 ` [PATCH v3] KVM: x86 emulator: add LDS/LES/LFS/LGS/LSS instruction emulation Wei Yongjun
2010-08-23 23:26 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6E4638.7070507@redhat.com \
--to=pbonzini@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.