Re: [PATCH] xl: improve vif2 parsing

[Andre Przywara <andre.przywara@amd.com>]

Gianni Tedesco wrote:
> On Fri, 2010-08-20 at 13:03 +0100, Andre Przywara wrote:
>> Andre Przywara wrote:
>>> Hi,
>>>
>>> vif2 parsing relies on counted strncmp() statements. Replace this
>>> with a more robust automatic version.
>> No, I didn't want to leave this as an exercise to the reader, I am just
>> spoiled by git send-email, so forgot to attach the patch. Sorry!
>>
>>> Signed-off-by: Andre Przywara <andre.przywara@amd.com>
>>>
> 
> Both patches look good to me.
> 
>>> Regards,
>>> Andre.
>>>
>>> P.S. If you like this, I have seen at least two more instances of the 
>>> same issue that could be improved this way.
>>>
> 
> Can you say where?
In main_networkattach() and main_network2attach().

> 
> You should be aware that disk config parsing is undergoing a rewrite
> already so lets not duplicate efforts on that one ;)
I hoped you would say something like this. I see that parts of the code 
has issues:
* xl_cmdimpl.c is way too long (and will probably still have to grow)
* code duplication in several parameter parsers
* not reentrant safe (strtok instead of strtok_r)
* Coding style (mostly 80 character limit)

So I was hoping that code cleanup was on someone's list, that saves me 
from fixing many smaller things.

Regards,
Andre.


Btw. I saw that cpuid= is still missing in libxl, I have a version 
improved over the clumsy xm interface 90% ready, but will probably not 
able to send it out still this week.

-- 
Andre Przywara
AMD-OSRC (Dresden)
Tel: x29712