Re: [PATCH 1/2] mmc: USB SD Host Controller (USHC) driver

[David Vrabel <david.vrabel@csr.com>]

Nicolas Pitre wrote:
> On Thu, 19 Aug 2010, David Vrabel wrote:
> 
>> +	  Note: Version 2 devices only support SDIO cards/devices.
> 
> Do you mean that only the devices with version 2 do support SDIO, or 
> that devices with version 2 support SDIO only?

I've revised the wording to:

  Note: These controllers only support SDIO cards and do not
  support MMC or SD memory cards.

This is because the protocol doesn't support the long R2 response format.

>> +	mmc->f_min = 0;
>> +	mmc->f_max = 50000000;
> 
> Why are you setting mmc->f_min to zero?  I understand that the 6000000 
> limit is only for commands with data, but a limit of 0 is rather ... 
> unusual.

f_min should be 400 kHz.

I'll wait and see if there are any other review comments before posted
an updated patch.

David
-- 
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom