All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: LVM2/lib/report properties.c
Date: Fri, 20 Aug 2010 15:49:29 +0200	[thread overview]
Message-ID: <4C6E87E9.9040109@redhat.com> (raw)
In-Reply-To: <20100820130240.24771.qmail@sourceware.org>

Dne 20.8.2010 15:02, wysochanski at sourceware.org napsal(a):
> CVSROOT:	/cvs/lvm2
> Module name:	LVM2
> Changes by:	wysochanski at sourceware.org	2010-08-20 13:02:39
> 
> Modified files:
> 	lib/report     : properties.c 
> 
> Log message:
> 	Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
> 
> Patches:
> http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/report/properties.c.diff?cvsroot=lvm2&r1=1.2&r2=1.3
> 
> --- LVM2/lib/report/properties.c	2010/08/20 12:45:09	1.2
> +++ LVM2/lib/report/properties.c	2010/08/20 13:02:39	1.3
> @@ -20,6 +20,15 @@
>  #include "lvm-types.h"
>  #include "metadata.h"
>  
> +#define GET_NUM_PROPERTY_FN(NAME, VALUE) \
> +static int _ ## NAME ## _get (void *obj, struct lvm_property_type *prop) \
> +{ \
> +	struct volume_group *vg = (struct volume_group *)obj; \
> +\
> +	prop->v.n_val = VALUE; \
> +	return 1; \
> +}
> +


Is this going to be part of liblvm API - or it's only purpose is to be used
through liblvm2api - in that case it would be better to have this code
compiled as a part of liblvm2api library and not increasing size of liblvm ?

Zdenek



  reply	other threads:[~2010-08-20 13:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-20 13:02 LVM2/lib/report properties.c wysochanski
2010-08-20 13:49 ` Zdenek Kabelac [this message]
2010-08-20 14:45   ` Dave Wysochanski
2010-08-20 17:08     ` Alasdair G Kergon
  -- strict thread matches above, loose matches on Subject: below --
2010-11-25 14:39 mornfall
2010-10-12 16:11 wysochanski
2010-09-30 14:09 wysochanski
2010-09-30 14:08 wysochanski
2010-09-30 14:08 wysochanski
2010-09-09 19:38 wysochanski
2010-08-20 12:45 wysochanski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C6E87E9.9040109@redhat.com \
    --to=zkabelac@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.