From: Arnd Hannemann <arnd@arndnet.de>
To: Yusuke Goda <yusuke.goda.sx@renesas.com>
Cc: ian@mnementh.co.uk, damm@opensource.se, sameo@linux.intel.com,
Paul Mundt <lethal@linux-sh.org>,
g.liakhovetski@gmx.de, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] tmio_mmc: Make ack_mmc_irqs() write-only
Date: Fri, 20 Aug 2010 17:12:53 +0200 [thread overview]
Message-ID: <4C6E9B75.8030004@arndnet.de> (raw)
In-Reply-To: <4C455597.2020200@renesas.com>
Am 20.07.2010 09:51, schrieb Yusuke Goda:
> This patch updates ack_mmc_irqs() to acknowledge using write instead
> of read-modify-write. Without this fix the old read-modify-write
> implementation may acknowledge interrupt sources by mistake. The
> driver may if so lock-up waiting forever for an interrupt that will
> never come. Observed with the TMIO_STAT_RXRDY bit together with
> CMD53 on AR6002 and BCM4318 SDIO cards in polled mode.
>
> Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
Tested on AP4EVB (sh7372) with SDHC and MMC cards - no regression.
Tested-by: Arnd Hannemann <arnd@arndnet.de>
next prev parent reply other threads:[~2010-08-20 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 7:51 [PATCH] tmio_mmc: Make ack_mmc_irqs() write-only Yusuke Goda
2010-07-23 11:10 ` Magnus Damm
2010-08-20 15:12 ` Arnd Hannemann [this message]
2010-08-20 22:55 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6E9B75.8030004@arndnet.de \
--to=arnd@arndnet.de \
--cc=akpm@linux-foundation.org \
--cc=damm@opensource.se \
--cc=g.liakhovetski@gmx.de \
--cc=ian@mnementh.co.uk \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=yusuke.goda.sx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.