From: Tejun Heo <tj@kernel.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: stefan.huebner@stud.tu-ilmenau.de, jgarzik@pobox.com,
linux-ide@vger.kernel.org
Subject: Re: Maybe a bug in libata-core
Date: Mon, 23 Aug 2010 11:27:01 +0200 [thread overview]
Message-ID: <4C723EE5.9050408@kernel.org> (raw)
In-Reply-To: <20100823104400.37cfb3f0@lxorguk.ukuu.org.uk>
Hello,
On 08/23/2010 11:44 AM, Alan Cox wrote:
> It's user triggerable (as root I grant) so really shouldn't be
> generating WARNs in that case either - just an -EIO.
I still want to keep WARN_ON_ONCE() tho. It will help detecting
possible breakage in the many code paths prepping data vectors through
block, SCSI, DMA API and whatnot. Silent AC_ERR_SYSTEM failure can be
pretty difficult to track down and it's not like WARN_ON_ONCE() can be
used as an attack vector.
Thanks.
--
tejun
next prev parent reply other threads:[~2010-08-23 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 0:52 Fwd: Maybe a bug in libata-core Stefan /*St0fF*/ Hübner
2010-08-23 9:16 ` Tejun Heo
2010-08-23 9:27 ` [PATCH #upstream-fixes] libata: be less of a drama queen on empty data commands Tejun Heo
2010-08-23 9:44 ` Maybe a bug in libata-core Alan Cox
2010-08-23 9:27 ` Tejun Heo [this message]
2010-08-23 22:41 ` Stefan /*St0fF*/ Hübner
2010-08-24 7:27 ` Tejun Heo
2010-09-09 5:42 ` Stefan /*St0fF*/ Hübner
-- strict thread matches above, loose matches on Subject: below --
2010-08-20 21:48 Stefan Hübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C723EE5.9050408@kernel.org \
--to=tj@kernel.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=stefan.huebner@stud.tu-ilmenau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.