From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?THVrw6HFoSBEb2t0b3I=?= Subject: Re: [KVM-autotest] virtio_console test Date: Mon, 23 Aug 2010 15:20:17 +0200 Message-ID: <4C727591.7050808@redhat.com> References: <1282311612-3282-1-git-send-email-ldoktor@redhat.com> <4C6E8D63.6080409@redhat.com> <20100823075346.GG2721@amit-laptop.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: jzupka@redhat.com, autotest@test.kernel.org, kvm@vger.kernel.org, akong@redhat.com To: Amit Shah Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52159 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751631Ab0HWNUU (ORCPT ); Mon, 23 Aug 2010 09:20:20 -0400 In-Reply-To: <20100823075346.GG2721@amit-laptop.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Hi Amit, Dne 23.8.2010 09:53, Amit Shah napsal(a): > On (Fri) Aug 20 2010 [16:12:51], Luk=C3=A1=C5=A1 Doktor wrote: >> Dne 20.8.2010 15:40, Lukas Doktor napsal(a): >>> Hi, >>> >>> This patch adds new test for virtio_console. It supports booth, ser= ialport and console, virtio_console types and it contains three tests: >>> 1) smoke >>> 2) loopback >>> 3) perf > > This is great, thanks for the tests. > > I was working with Lucas at the KVM Forum to get my virtio-console te= sts > integrated upstream. I have a few micro tests that test correctness o= f > various bits in the virtio_console code: > > http://fedorapeople.org/gitweb?p=3Damitshah/public_git/test-virtseria= l.git yes, I'm aware of your tests and the fedora page about virtio-console. = I=20 took an inspiration from them ;-) (thanks) > > It would be great to sync up with Lucas and add those tests to autote= st > as well. I went through the code trying to find tests missing in our autotest=20 virtio_console.py test. Correct me if I'm wrong, but the missing tests = are: * variations on opening/writing/reading host/guest closed/open consoles= =20 and check the right handling * guest caching (if necessarily) > > Eventually, I'd also like to adapt the C code to python so that it > integrates with KVM-autotest. > Yes, either you or I can do that. I would just need the=20 test-requirement-list. >> Just a note about kernels: >> serialport works great but console have big issues. Use kernels>=3D >> 2.6.35 for testing. > > Can you tell me what the issues are? I test console io in the testsui= te > mentioned above and it's been passing fine. > Sometimes on F13 there were Oops while booting guests with virtconsoles= =2E=20 Also the sysfs informations about virtconsoles were sometimes=20 mismatched. With vanilla kernel 2.6.35 it worked better with occasional= =20 Oops while booting the guest. My colleague was working on that part so when he's back from holiday he= =20 can provide more information. With virtserialport it always worked correctly. > Amit Luk=C3=A1=C5=A1