From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Cousson, Benoit" Subject: Re: [PATCH 15/20] Use platform device to get DSS base addr Date: Mon, 23 Aug 2010 23:43:12 +0200 Message-ID: <4C72EB70.7000606@ti.com> References: <1282579089-10487-1-git-send-email-svadivu@ti.com> <1282579089-10487-2-git-send-email-svadivu@ti.com> <1282579089-10487-3-git-send-email-svadivu@ti.com> <1282579089-10487-4-git-send-email-svadivu@ti.com> <1282579089-10487-5-git-send-email-svadivu@ti.com> <1282579089-10487-6-git-send-email-svadivu@ti.com> <1282579089-10487-7-git-send-email-svadivu@ti.com> <1282579089-10487-8-git-send-email-svadivu@ti.com> <1282579089-10487-9-git-send-email-svadivu@ti.com> <1282579089-10487-10-git-send-email-svadivu@ti.com> <1282579089-10487-11-git-send-email-svadivu@ti.com> <1282579089-10487-12-git-send-email-svadivu@ti.com> <1282579089-10487-13-git-send-email-svadivu@ti.com> <1282579089-10487-14-git-send-email-svadivu@ti.com> <1282579089-10487-15-git-send-email-svadivu@ti.com> <1282579089-10487 -16-git-send-email-svadivu@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:54880 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754511Ab0HWVnU (ORCPT ); Mon, 23 Aug 2010 17:43:20 -0400 In-Reply-To: <1282579089-10487-16-git-send-email-svadivu@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Guruswamy, Senthilvadivu" Cc: "linux-omap@vger.kernel.org" , "tomi.valkeinen@nokia.com" , "paul@pwsan.com" , "Hilman, Kevin" On 8/23/2010 5:58 PM, Guruswamy, Senthilvadivu wrote: > From: Senthilvadivu Guruswamy > > DSS Base addr got form platform device. Hardcoding of base addr could be removed. > > Signed-off-by: Senthilvadivu Guruswamy > --- > drivers/video/omap2/dss/dss.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/omap2/dss/dss.c b/drivers/video/omap2/dss/dss.c > index cbad9ff..21005c6 100644 > --- a/drivers/video/omap2/dss/dss.c > +++ b/drivers/video/omap2/dss/dss.c > @@ -973,8 +973,10 @@ int dss_init(bool skip_init) > { > int r; > u32 rev; > + struct resource *dss_mem; > > - dss.base = ioremap(DSS_BASE, DSS_SZ_REGS); > + dss_mem = platform_get_resource(dss.pdev, IORESOURCE_MEM, 0); platform_get_resource can fail, so you have to check the returned value. Please note that this comment applies as well to all the other patches from 16 to 19. Benoit > + dss.base = ioremap(dss_mem->start, resource_size(dss_mem)); > if (!dss.base) { > DSSERR("can't ioremap DSS\n"); > r = -ENOMEM;