From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1OoD0I-0003MR-T8 for mharc-grub-devel@gnu.org; Wed, 25 Aug 2010 06:14:46 -0400 Received: from [140.186.70.92] (port=47900 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OoD0F-0003LR-Op for grub-devel@gnu.org; Wed, 25 Aug 2010 06:14:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OoD0E-0006mH-Il for grub-devel@gnu.org; Wed, 25 Aug 2010 06:14:43 -0400 Received: from mail-bw0-f41.google.com ([209.85.214.41]:43899) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OoD0E-0006kQ-EJ for grub-devel@gnu.org; Wed, 25 Aug 2010 06:14:42 -0400 Received: by bwz6 with SMTP id 6so578362bwz.0 for ; Wed, 25 Aug 2010 03:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=l1eUX8+o4ikXYjx1lizOYXB9R8A+J8SjJRppC1ifyng=; b=QjGbO3ftTiNDOqqTfGymUVaYnfdmo0t9YQS8tYnFyQfpAWMUmmUtoaaEzMdT2zhTUM OW9/gdRg1sH6MnI5KRxLCnr1MrA+3p/ZM/v8myJi7QzThnjSBIWYyprop9/1thlNNozs MjF/8wJoGGcCikh0HetOnTHCU0rtcV/Y3RbDE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=hkNLo3U5QT/BfKlSny7Y6hnyQvdpUYdVMLtMBa95Aw8+MKf+QV34XxC9kR/JcBbdaW aoL0dDrHUPbgLmSvg/GcxhrvptUeAOFd+cfKbSs0CEDUM56soLfu43CkYmAKCev97qlI uZ5wUD3NNZ5U6d+a2QSgn0PxYc8UXJyLW5NTU= Received: by 10.204.51.77 with SMTP id c13mr5716180bkg.98.1282731281245; Wed, 25 Aug 2010 03:14:41 -0700 (PDT) Received: from debian.bg45.phnet (gprs41.swisscom-mobile.ch [193.247.250.41]) by mx.google.com with ESMTPS id x19sm887269bkv.9.2010.08.25.03.14.39 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 25 Aug 2010 03:14:40 -0700 (PDT) Message-ID: <4C74ED04.9010803@gmail.com> Date: Wed, 25 Aug 2010 12:14:28 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100805 Icedove/3.0.6 MIME-Version: 1.0 To: grub-devel@gnu.org References: In-Reply-To: X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig626100323B6285C3DC387468" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Fix for echo command on unrecognized options X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Aug 2010 10:14:45 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig626100323B6285C3DC387468 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/25/2010 06:35 AM, BVK Chaitanya wrote: > Hi, > > > Attached patch fixes echo command behavior for unrecognized options. > On BASH echo command passes all unrecognized options to the output, > this patch makes GRUB version to behave similarly. This bug has been > reported by Yves Blusseau (JrCs). > > =20 This patch parses options manually but still fails to replicate the 'echo' behaviour. 1) echo erere -n outputs "erere -n" 2) We can still use extcmd, it just needs minor modifications to accept flags GRUB_COMMAND_FLAG_ACCEPT_DASHARG (put -x and --xyz into args[]) and GRUB_COMMAND_FLAG_BSD_STYLE (options precede arguments). As an advantage the options are still listed in help and it may be useful for other things as well (e.g. pending nounzip patch) > --- ChangeLog 2010-08-23 17:56:24 +0000 > +++ ChangeLog 2010-08-25 04:19:18 +0000 > @@ -1,3 +1,14 @@ > +2010-08-25 BVK Chaitanya > + > + Fix echo command output for unrecognized options (bug reported by > + Yves Blusseau) > + > + * tests/grub_cmd_echo.in: New testcase. > + * Makefile.util.def: Rules for new testcase. > + > + * grub-core/commands/echo.c: Use custom option parsing instead of > + extcmd framework. > + > > > =20 > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig626100323B6285C3DC387468 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAkx07QQACgkQNak7dOguQgmPuAD8CbHdWCROfGiHPO6aKi5Lki3C bbiMsZaFjKzVoYuPOWMBAIDQV9tjVUfPbDabtKykGZYybIlNxMmRQC8wfdJPBsp1 =t+YS -----END PGP SIGNATURE----- --------------enig626100323B6285C3DC387468--