From: Jens Axboe <jaxboe@fusionio.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"arnd@arndb.de" <arnd@arndb.de>,
Daniel Stodden <daniel.stodden@citrix.com>
Subject: Re: you patch "block: push down BKL into .open and .release" and its changes to xen-blkfront.c
Date: Wed, 25 Aug 2010 13:02:09 +0200 [thread overview]
Message-ID: <4C74F831.3040400@fusionio.com> (raw)
In-Reply-To: <4C7513AB0200007800012130@vpn.id2.novell.com>
On 2010-08-25 12:59, Jan Beulich wrote:
> Arnd,
>
> what was the point of adding {,un}lock_kernel() to blkif_open() and
> blkif_release()? Afaict, the associated bdev is protected by a mutex
> anyway, so even without Daniel's addition of a mutex to these
> paths I don't see the need for the BKL here.
I'll let Arnd answer for himself, but at least in general it's
much easier to let this sort of auditing and final cleanup
be done my the maintainer(s) of the driver in question, as they
are best positioned to verify that the BKL in fact isn't
really necessary in that path anymore.
--
Jens Axboe
next prev parent reply other threads:[~2010-08-25 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 10:59 you patch "block: push down BKL into .open and .release" and its changes to xen-blkfront.c Jan Beulich
2010-08-25 11:02 ` Jens Axboe [this message]
2010-08-25 11:28 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C74F831.3040400@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=JBeulich@novell.com \
--cc=arnd@arndb.de \
--cc=daniel.stodden@citrix.com \
--cc=jeremy@goop.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.