From: Brian King <brking@linux.vnet.ibm.com>
To: Anton Blanchard <anton@samba.org>,
santil@linux.vnet.ibm.com, netdev@vger.kernel.org
Subject: Re: [patch 08/20] ibmveth: Dont overallocate buffers
Date: Wed, 25 Aug 2010 08:44:16 -0500 [thread overview]
Message-ID: <4C751E30.6020408@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100823204916.GB15499@linux.vnet.ibm.com>
On 08/23/2010 03:49 PM, Robert Jennings wrote:
> * Anton Blanchard (anton@samba.org) wrote:
>> We were allocating a page, even though we always want 4k. Use kmalloc
>> instead of get_zeroed_page.
>
> I get a failure during device open when we have a 4k allocation rather
> than a 64k page allocation. This is running on a Power6 LPAR without
> AMS.
>
> (drivers/net/ibmveth.c:621 ua:3000000c) ERROR: h_register_logical_lan failed with -4
> (drivers/net/ibmveth.c:626 ua:3000000c) ERROR: buffer TCE:0x300 filter TCE:0x2300 rxq desc:0x8000601000004000 MAC:0x763cbdd9d30c
According to the architecture, these buffers need to be 4k aligned buffers,
which is probably the cause of this failure.
-Brian
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
next prev parent reply other threads:[~2010-08-25 13:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 0:09 [patch 00/20] ibmveth update Anton Blanchard
2010-08-23 0:09 ` [patch 01/20] ibmveth: Remove integer divide caused by modulus Anton Blanchard
2010-08-23 0:09 ` [patch 02/20] ibmveth: batch rx buffer replacement Anton Blanchard
2010-08-23 0:09 ` [patch 03/20] ibmveth: Remove LLTX Anton Blanchard
2010-08-23 0:09 ` [patch 04/20] ibmveth: Add tx_copybreak Anton Blanchard
2010-08-23 0:09 ` [patch 05/20] ibmveth: Add rx_copybreak Anton Blanchard
2010-08-23 0:09 ` [patch 06/20] ibmveth: Use lighter weight read memory barrier in ibmveth_poll Anton Blanchard
2010-08-23 0:09 ` [patch 07/20] ibmveth: Add scatter-gather support Anton Blanchard
2010-08-23 0:09 ` [patch 08/20] ibmveth: Dont overallocate buffers Anton Blanchard
2010-08-23 20:49 ` Robert Jennings
2010-08-25 13:44 ` Brian King [this message]
2010-08-23 0:09 ` [patch 09/20] ibmveth: Add optional flush of rx buffer Anton Blanchard
2010-08-23 0:09 ` [patch 10/20] ibmveth: remove procfs code Anton Blanchard
2010-08-23 0:09 ` [patch 11/20] ibmveth: Convert to netdev_alloc_skb Anton Blanchard
2010-08-23 0:09 ` [patch 12/20] ibmveth: Remove redundant function prototypes Anton Blanchard
2010-08-23 0:09 ` [patch 13/20] ibmveth: Convert driver specific debug to netdev_dbg Anton Blanchard
2010-08-23 0:09 ` [patch 14/20] ibmveth: Convert driver specific error functions to netdev_err Anton Blanchard
2010-08-23 0:09 ` [patch 15/20] ibmveth: Some formatting fixes Anton Blanchard
2010-08-23 0:09 ` [patch 16/20] ibmveth: Coding style fixes Anton Blanchard
2010-08-23 0:09 ` [patch 17/20] ibmveth: Return -EINVAL on all ->probe errors Anton Blanchard
2010-08-23 0:09 ` [patch 18/20] ibmveth: Convert driver specific assert to BUG_ON Anton Blanchard
2010-08-23 0:09 ` [patch 19/20] ibmveth: Remove some unnecessary include files Anton Blanchard
2010-08-23 0:09 ` [patch 20/20] ibmveth: Update module information and version Anton Blanchard
2010-08-23 1:57 ` [patch 00/20] ibmveth update David Miller
2010-08-23 2:07 ` Anton Blanchard
2010-08-23 2:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C751E30.6020408@linux.vnet.ibm.com \
--to=brking@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=netdev@vger.kernel.org \
--cc=santil@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.