From: Tejun Heo <tj@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] workqueue: fix cwq->nr_active underflow
Date: Wed, 25 Aug 2010 16:21:56 +0200 [thread overview]
Message-ID: <4C752704.1030806@kernel.org> (raw)
In-Reply-To: <1282746326.3667.8.camel@jlt3.sipsolutions.net>
On 08/25/2010 04:25 PM, Johannes Berg wrote:
> On Wed, 2010-08-25 at 11:12 +0200, Tejun Heo wrote:
>
>> Yeap, without the fix patch applied, that should confirm that we're
>> seeing the same failure, and with the patch applied, you can add a
>> printk in the else part of !delayed check in cwq_dec_nr_in_flight().
>> If the printk triggers and later rmmod dosen't trigger BUG_ON(), we
>> can be fairly sure the problem is fixed.
>
> Unfortunately, I haven't been able to trigger either code path today.
> I'll happily believe that this was the problem though, and will just let
> you know if I run into it again, I'm keeping the debug patch for now.
> It's certainly a valid fix regardless of whether I can reproduce the
> problem or not.
Thanks. I'll push it to Linus tomorrow.
--
tejun
prev parent reply other threads:[~2010-08-25 14:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 8:52 [PATCH] workqueue: fix cwq->nr_active underflow Tejun Heo
2010-08-25 9:11 ` Johannes Berg
2010-08-25 9:12 ` Tejun Heo
2010-08-25 9:20 ` Johannes Berg
2010-08-25 14:25 ` Johannes Berg
2010-08-25 14:21 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C752704.1030806@kernel.org \
--to=tj@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.