All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hollis Blanchard <hollis_blanchard@mentor.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] vhost_net.c broken by --kerneldir
Date: Wed, 25 Aug 2010 10:22:45 -0700	[thread overview]
Message-ID: <4C755165.4040804@mentor.com> (raw)
In-Reply-To: <201008251537.27679.arnd@arndb.de>

On 08/25/2010 06:37 AM, Arnd Bergmann wrote:
> On Wednesday 25 August 2010, Hollis Blanchard wrote:
>    
>> The problem seems to be that jump from /usr/include/bits/sigcontext.h to
>> asm/sigcontext.h inside<kerneldir>  rather than inside /usr/include. It
>> seems like adding -Ikerneldir/arch/foo/include will always be a problem,
>> since it will always be used to satisfy "#include<asm/bar.h>". Only
>> files built with KVM_CFLAGS would be affected, and I guess vhost_net.c
>> accidentally gets into a broken include path where the other KVM_CFLAGS
>> files doesn't.
>>
>> I'm wondering why this isn't causing more problems for more people. My
>> host is Fedora 12, FWIW, but this doesn't seem like it could at all be
>> related to toolchain version, for example.
>>      
> We only recently fixed the kernel to have this warning in types.h, which
> triggers more often than kernel.h, where it used to be before. In 2.6.35
> and before, you consequently would not have noticed the problem.
>    

Thanks Arnd, that explains it.

It looks like the --kerneldir option needs to be re-thought.

Hollis Blanchard
Mentor Graphics, Embedded Systems Division

  reply	other threads:[~2010-08-25 17:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-25  0:55 [Qemu-devel] vhost_net.c broken by --kerneldir Hollis Blanchard
2010-08-25 13:37 ` Arnd Bergmann
2010-08-25 17:22   ` Hollis Blanchard [this message]
2010-08-26 15:15     ` Arnd Bergmann
2010-08-26 15:21       ` Gleb Natapov
2010-08-26 15:48         ` Anthony Liguori
2010-08-26 16:41           ` Hollis Blanchard
2010-08-26 19:01             ` Anthony Liguori
2010-08-26 15:50         ` Arnd Bergmann
2010-09-03 10:57       ` Michael S. Tsirkin
2010-08-25 17:21 ` [Qemu-devel] " Hollis Blanchard
2010-08-26  6:29   ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C755165.4040804@mentor.com \
    --to=hollis_blanchard@mentor.com \
    --cc=arnd@arndb.de \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.