From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Greear Subject: Re: [net-next 2/2] macvlan: Enable qdisc backoff logic. Date: Wed, 25 Aug 2010 13:49:22 -0700 Message-ID: <4C7581D2.3010007@candelatech.com> References: <1282762851-3612-1-git-send-email-greearb@candelatech.com> <201008252124.09917.arnd@arndb.de> <4C756EAF.9090704@candelatech.com> <201008252159.11227.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Arnd Bergmann Return-path: Received: from mail.candelatech.com ([208.74.158.172]:38568 "EHLO ns3.lanforge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751615Ab0HYUtZ (ORCPT ); Wed, 25 Aug 2010 16:49:25 -0400 In-Reply-To: <201008252159.11227.arnd@arndb.de> Sender: netdev-owner@vger.kernel.org List-ID: On 08/25/2010 12:59 PM, Arnd Bergmann wrote: > On Wednesday 25 August 2010 21:27:43 Ben Greear wrote: >>> I suppose we need to do something in macvtap to handle this as >>> well, right? A guest trying to send a frame through qemu >>> or vhost net into macvtap needs to be prevented from sending >>> more when we get into this path. Right now, we just ignore >>> the return value of macvlan_start_xmit. >> >> I have a similar, though slightly more complex, patch for 802.1q >> vlans, but I haven't looked at macvtap at all. >> >> If these two patches are accepted, I'll post the .1q patch as well. > > I think one of us needs to fix macvtap in order for your patch to > go in, because otherwise there is a memory leak or worse when > macvtap fails to retransmit the frame. With no change, the try_ logic will not be called, so it should be fully backwards compatible. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com