From: "H. Peter Anvin" <hpa@zytor.com>
To: Sebastien Hinderer <Sebastien.Hinderer@ens-lyon.org>
Cc: Andreas Mohr <andi@lisas.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Len Brown <len.brown@intel.com>,
linux-kernel@vger.kernel.org,
Samuel Thibault <Samuel.Thibault@ens-lyon.org>
Subject: Re: [PATCH] x86: EuroBraille/Iris power off
Date: Wed, 25 Aug 2010 14:19:55 -0700 [thread overview]
Message-ID: <4C7588FB.4050001@zytor.com> (raw)
In-Reply-To: <20100825211257.GA636@pema>
On 08/25/2010 02:12 PM, Sebastien Hinderer wrote:
> Hi,
>
>> excellent! Now if as the next step before inclusion you also add the usual DMI check
>> (as done by many drivers such as acerhdf etc.),
>> someone inexperienced who is dumb enough to enable it for his unrelated machine
>> will actually survive an otherwise raw I/O port access and poweroff
>> vector change ;))
>
> The machine does not support DMI, I have mentionned that in the module.
>
Perhaps a better questions is: what *do* they have? I really don't feel
comfortable adding something like this which pokes at a random port in
the ISA range, especially with the Interrupt list listing 6 known other
uses of this particular port.
At that point I'd almost prefer doing something like a BIOS signature
check if we can't do anything better.
-hpa
next prev parent reply other threads:[~2010-08-25 21:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 9:49 [PATCH] x86: EuroBraille/Iris power off Shérab
2010-08-25 16:12 ` Andreas Mohr
2010-08-25 21:12 ` Sebastien Hinderer
2010-08-25 21:19 ` H. Peter Anvin [this message]
2010-08-25 22:50 ` Samuel Thibault
2010-08-26 0:06 ` H. Peter Anvin
2010-08-26 0:19 ` Samuel Thibault
2010-08-26 6:45 ` Sebastien Hinderer
2010-08-26 6:55 ` H. Peter Anvin
2010-08-26 7:09 ` Andreas Mohr
2010-08-26 9:29 ` Sebastien Hinderer
2010-08-26 18:11 ` Len Brown
2010-08-26 21:08 ` Shérab
2010-08-26 21:16 ` H. Peter Anvin
2010-08-27 17:35 ` Shérab
2010-08-27 18:49 ` H. Peter Anvin
2010-08-27 22:27 ` Shérab
2010-08-29 20:59 ` Shérab
2010-09-13 10:07 ` Shérab
2010-09-13 15:10 ` Valdis.Kletnieks
2010-09-13 15:22 ` Samuel Thibault
2010-09-13 16:06 ` H. Peter Anvin
2010-09-13 16:12 ` Samuel Thibault
2010-09-14 1:45 ` Valdis.Kletnieks
2010-09-14 5:16 ` Shérab
2010-09-20 8:22 ` Shérab
2010-09-26 17:54 ` Shérab
2010-10-10 16:22 ` Shérab
2010-11-13 19:22 ` Shérab
2010-09-13 15:25 ` Shérab
2010-09-13 15:48 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7588FB.4050001@zytor.com \
--to=hpa@zytor.com \
--cc=Samuel.Thibault@ens-lyon.org \
--cc=Sebastien.Hinderer@ens-lyon.org \
--cc=akpm@linux-foundation.org \
--cc=andi@lisas.de \
--cc=fweisbec@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.