All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Hoogenraad <jan-conceptronic@hoogenraad.net>
To: linux-media <linux-media@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Subject: ir_codes_dibusb_table : please make table length a constant
Date: Thu, 26 Aug 2010 08:53:19 +0200	[thread overview]
Message-ID: <4C760F5F.8000801@hoogenraad.net> (raw)
In-Reply-To: <4C75FF0B.3060500@hoogenraad.net>

During debugging a driver, I found that at least in

linux/drivers/media/dvb/dvb-usb/dibusb-mc.c	
the length of ir_codes_dibusb_table was referring to an older version.
This may have caused memory overrun problems

I have fixed this in my branch in
linux/drivers/media/dvb/dvb-usb/dibusb.h
  with a
#define IR_CODES_DIBUSB_TABLE_LEN 111

http://linuxtv.org/hg/~jhoogenraad/rtl2831-r2/rev/549b40b69fa4

I agree this is not the nicest solution, but at at least would reduce 
some problems.
I am not sure on how to create a patch for this ?
Should I make a new branch in the HG archive ?

I suggest to replate the 111-s into IR_CODES_DIBUSB_TABLE_LEN in the 
files below as well:

     * drivers/media/dvb/dvb-usb/dibusb-common.c:
           o line 330
           o line 459
     * drivers/media/dvb/dvb-usb/dibusb-mb.c:
           o line 215
           o line 299
           o line 363
           o line 420
     * drivers/media/dvb/dvb-usb/dibusb.h, line 127

-- 
Jan Hoogenraad
Hoogenraad Interface Services
Postbus 2717
3500 GS Utrecht

  reply	other threads:[~2010-08-26  6:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-03  6:36 V4L hg tree fails to compile against latest stable kernel 2.6.35 VDR User
2010-08-03  6:44 ` VDR User
     [not found]   ` <4C581BB6.7000303@redhat.com>
2010-08-05  5:19     ` Douglas Schilling Landgraf
2010-08-05  5:44       ` VDR User
2010-08-05 15:07         ` Douglas Schilling Landgraf
2010-08-14 16:46       ` VDR User
2010-08-15  5:22         ` Douglas Schilling Landgraf
2010-08-15 17:57           ` Douglas Schilling Landgraf
2010-08-15 18:50             ` VDR User
2010-08-24 20:04             ` V4L hg tree fails to compile against kernel 2.6.28 Jan Hoogenraad
2010-08-25  3:45               ` Douglas Schilling Landgraf
2010-08-25  5:21                 ` Douglas Schilling Landgraf
2010-08-25  6:26                 ` Jan Hoogenraad
2010-08-25 19:26                   ` Douglas Schilling Landgraf
2010-08-26  5:43                     ` Jan Hoogenraad
2010-08-26  6:53                       ` Jan Hoogenraad [this message]
2010-08-27  1:32                         ` ir_codes_dibusb_table : please make table length a constant Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C760F5F.8000801@hoogenraad.net \
    --to=jan-conceptronic@hoogenraad.net \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.