All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Do not scan snapshot origin for labels while 'ignore_suspended_devices()' is set
Date: Thu, 26 Aug 2010 10:10:44 +0200	[thread overview]
Message-ID: <4C762184.9000307@redhat.com> (raw)
In-Reply-To: <1282747088.10709.1.camel@hydrogen.msp.redhat.com>

On 08/25/2010 04:38 PM, Jonathan Brassow wrote:

> +		 * Snapshot origin could be sitting on top of a mirror which
> +		 * could be blocking I/O.  Skip snapshot origins entirely for
> +		 * now.
> +		 *
> +		 * FIXME: rather than skipping origin, check if mirror is
> +		 * underneath and if the mirror is blocking I/O.
> +		 */
> +		if (target_type && !strcmp(target_type, "snapshot-origin") &&
> +		    ignore_suspended_devices()) {
> +			log_debug("%s: Snapshot-origin device %s not usable.",
> +				  dev_name(dev), name);
> +			goto out;

Well, if no one can find situation where this breaks some existing config,
let's try that - we need something working in this release.

The code need rewrite here anyway... ack from me for now.

Milan



  reply	other threads:[~2010-08-26  8:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-25 14:38 [PATCH] Do not scan snapshot origin for labels while 'ignore_suspended_devices()' is set Jonathan Brassow
2010-08-26  8:10 ` Milan Broz [this message]
2010-08-26 12:31   ` Petr Rockai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C762184.9000307@redhat.com \
    --to=mbroz@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.