From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Fix zombie mirror poll daemon (bug 585328)
Date: Thu, 26 Aug 2010 10:17:56 +0200 [thread overview]
Message-ID: <4C762334.8060403@redhat.com> (raw)
In-Reply-To: <1282772027.18079.3.camel@hydrogen.msp.redhat.com>
On 08/25/2010 11:33 PM, Jonathan Brassow wrote:
> - if (!lv_mirror_percent(cmd, lv, !parms->interval, &segment_percent,
> + if (!(lv->status & MIRRORED) ||
> + !lv_mirror_percent(cmd, lv, !parms->interval, &segment_percent,
> &percent_range, &event_nr) ||
> (percent_range == PERCENT_INVALID)) {
> log_error("ABORTING: Mirror percentage check failed.");
why not move this check inside lv_mirror_percent?
(or is this only place where the bug can appear?)
(and it should probably use !lv_is_mirrored(lv) instead of mask)
otherwise ack
Milan
next prev parent reply other threads:[~2010-08-26 8:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 21:33 [PATCH] Fix zombie mirror poll daemon (bug 585328) Jonathan Brassow
2010-08-26 8:17 ` Milan Broz [this message]
2010-08-26 12:35 ` Petr Rockai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C762334.8060403@redhat.com \
--to=mbroz@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.