From: Mike Rapoport <mike@compulab.co.il>
To: Arun Murthy <arun.murthy@stericsson.com>
Cc: sameo@linux.intel.com, riku.voipio@iki.fi,
linux-kernel@vger.kernel.org,
STEricsson_nomadik_linux@list.st.com,
linus.walleij@stericsson.com, srinidhi.kasagar@stericsson.com,
Mike Rapoport <mike@compulab.co.il>
Subject: Re: [PATCH 0/3] u8500: led and backlight driver
Date: Thu, 26 Aug 2010 13:15:28 +0300 [thread overview]
Message-ID: <4C763EC0.10807@compulab.co.il> (raw)
In-Reply-To: <1282805432-28523-1-git-send-email-arun.murthy@stericsson.com>
Arun Murthy wrote:
> Arun Murthy (3):
> mfd: ab8500-pwm: ab8500 pwm management
> backlight: u8500: backlight driver based on ab8500 pwm
> leds: ab8500-led: led driver based on ab8500 pwm
There are drivers/leds/leds-pwm.c and drivers/video/backlight/pwm_bl.c that
implement led and backlight drivers based on generic pwm interface.
Have you considered using those?
> drivers/leds/Kconfig | 9 ++
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-ab8500.c | 201 +++++++++++++++++++++++++++++++
> drivers/mfd/Kconfig | 8 ++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/ab8500-core.c | 7 +-
> drivers/mfd/ab8500-pwm.c | 191 ++++++++++++++++++++++++++++++
> drivers/video/backlight/Kconfig | 10 ++
> drivers/video/backlight/Makefile | 2 +-
> drivers/video/backlight/ab8500_bl.c | 209 +++++++++++++++++++++++++++++++++
> include/linux/mfd/ab8500.h | 5 +
> include/linux/mfd/abx500/ab8500-pwm.h | 32 +++++
> 12 files changed, 674 insertions(+), 2 deletions(-)
> create mode 100644 drivers/leds/leds-ab8500.c
> create mode 100644 drivers/mfd/ab8500-pwm.c
> create mode 100644 drivers/video/backlight/ab8500_bl.c
> create mode 100644 include/linux/mfd/abx500/ab8500-pwm.h
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2010-08-26 10:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 6:50 [PATCH 0/3] u8500: led and backlight driver Arun Murthy
2010-08-26 6:50 ` [PATCH 1/3] mfd: ab8500-pwm: ab8500 pwm management Arun Murthy
2010-08-26 6:50 ` [PATCH 2/3] backlight: u8500: backlight driver based on ab8500 pwm Arun Murthy
2010-08-26 6:50 ` [PATCH 3/3] leds: ab8500-led: led " Arun Murthy
2010-08-26 10:15 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C763EC0.10807@compulab.co.il \
--to=mike@compulab.co.il \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=arun.murthy@stericsson.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riku.voipio@iki.fi \
--cc=sameo@linux.intel.com \
--cc=srinidhi.kasagar@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.