From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: linux-next: Tree for August 25 (mm/slub) Date: Thu, 26 Aug 2010 21:17:18 +0300 Message-ID: <4C76AFAE.7010907@cs.helsinki.fi> References: <20100825132057.c8416bef.sfr@canb.auug.org.au> <20100825094559.bc652afe.randy.dunlap@oracle.com> <4C757D5E.1040307@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4C757D5E.1040307@oracle.com> Sender: owner-linux-mm@kvack.org To: Randy Dunlap Cc: Christoph Lameter , Stephen Rothwell , linux-mm@kvack.org, linux-next@vger.kernel.org, LKML List-Id: linux-next.vger.kernel.org On 25.8.2010 23.30, Randy Dunlap wrote: > On 08/25/10 12:07, Christoph Lameter wrote: >> On Wed, 25 Aug 2010, Randy Dunlap wrote: >> >>> mm/slub.c:1732: error: implicit declaration of function 'slab_pre_alloc_hook' >>> mm/slub.c:1751: error: implicit declaration of function 'slab_post_alloc_hook' >>> mm/slub.c:1881: error: implicit declaration of function 'slab_free_hook' >>> mm/slub.c:1886: error: implicit declaration of function 'slab_free_hook_irq' >> >> Empty functions are missing if the runtime debuggability option is >> compiled >> out. >> >> >> Subject: slub: Add dummy functions for the !SLUB_DEBUG case >> >> Provide the fall back functions to empty hooks if SLUB_DEBUG is not set. >> >> Signed-off-by: Christoph Lameter > > Acked-by: Randy Dunlap Applied, thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753364Ab0HZSRj (ORCPT ); Thu, 26 Aug 2010 14:17:39 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:50290 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752983Ab0HZSRe (ORCPT ); Thu, 26 Aug 2010 14:17:34 -0400 Message-ID: <4C76AFAE.7010907@cs.helsinki.fi> Date: Thu, 26 Aug 2010 21:17:18 +0300 From: Pekka Enberg User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.2.8) Gecko/20100802 Thunderbird/3.1.2 MIME-Version: 1.0 To: Randy Dunlap CC: Christoph Lameter , Stephen Rothwell , linux-mm@kvack.org, linux-next@vger.kernel.org, LKML Subject: Re: linux-next: Tree for August 25 (mm/slub) References: <20100825132057.c8416bef.sfr@canb.auug.org.au> <20100825094559.bc652afe.randy.dunlap@oracle.com> <4C757D5E.1040307@oracle.com> In-Reply-To: <4C757D5E.1040307@oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25.8.2010 23.30, Randy Dunlap wrote: > On 08/25/10 12:07, Christoph Lameter wrote: >> On Wed, 25 Aug 2010, Randy Dunlap wrote: >> >>> mm/slub.c:1732: error: implicit declaration of function 'slab_pre_alloc_hook' >>> mm/slub.c:1751: error: implicit declaration of function 'slab_post_alloc_hook' >>> mm/slub.c:1881: error: implicit declaration of function 'slab_free_hook' >>> mm/slub.c:1886: error: implicit declaration of function 'slab_free_hook_irq' >> >> Empty functions are missing if the runtime debuggability option is >> compiled >> out. >> >> >> Subject: slub: Add dummy functions for the !SLUB_DEBUG case >> >> Provide the fall back functions to empty hooks if SLUB_DEBUG is not set. >> >> Signed-off-by: Christoph Lameter > > Acked-by: Randy Dunlap Applied, thanks!