All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Leeder <nleeder@codeaurora.org>
To: "Datta, Shubhrajyoti" <shubhrajyoti@ti.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Horace Fu <horace.fu@quantatw.com>,
	Mandeep Singh Baines <msb@chromium.org>
Subject: Re: [PATCH v2] input: mouse: add qci touchpad driver
Date: Thu, 26 Aug 2010 14:45:48 -0400	[thread overview]
Message-ID: <4C76B65C.9000702@codeaurora.org> (raw)
In-Reply-To: <0680EC522D0CC943BC586913CF3768C003B3909F9C@dbde02.ent.ti.com>

On 8/13/2010 4:36 AM, Datta, Shubhrajyoti wrote:
>
> Minor comments feel free to ignore if you feel so.

Thanks for reviewing this, I'll address these in the next patch.

>> +	err = i2c_master_send(context->ti2c_client, buf, 1);
>> +	if (err<  0)
>> +		goto i2c_fail;
>> +	msleep(100);
> Could you explain the time or have a #define XXX
>
Will add #define

>> +	gpio_direction_input(context->qcitp_gpio);
> The result is not checked here.

I'll check the result.

--
Neil
-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

      parent reply	other threads:[~2010-08-26 18:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-12 16:49 [PATCH v2] input: mouse: add qci touchpad driver Neil Leeder
2010-08-12 17:25 ` Stepan Moskovchenko
2010-08-12 17:58   ` Neil Leeder
2010-08-13  2:49     ` Dmitry Torokhov
2010-08-13 21:56       ` Neil Leeder
2010-08-14  0:54         ` Dmitry Torokhov
2010-08-17 17:14           ` Neil Leeder
2010-08-17 18:05             ` Dmitry Torokhov
2010-08-18 21:38               ` Neil Leeder
2010-08-19  5:33                 ` Dmitry Torokhov
2010-08-19 22:19                   ` Neil Leeder
2010-08-19 23:35                     ` Matthew Garrett
2010-08-20 19:16                       ` Neil Leeder
2010-08-25 18:26                     ` Neil Leeder
2010-08-26 14:49                       ` Dmitry Torokhov
2010-08-26 21:00                         ` Neil Leeder
2010-08-13  8:36 ` Datta, Shubhrajyoti
2010-08-13  9:34   ` Trilok Soni
2010-08-26 18:45   ` Neil Leeder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C76B65C.9000702@codeaurora.org \
    --to=nleeder@codeaurora.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=horace.fu@quantatw.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msb@chromium.org \
    --cc=shubhrajyoti@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.