All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernard F6BVP <f6bvp@free.fr>
To: ralf@linux-mips.org
Cc: davem@davemloft.net, linux-hams@vger.kernel.org,
	netdev@vger.kernel.org, bpidoux@free.fr
Subject: [PATCH] [AX25] missplaced sock_put(sk)
Date: Thu, 26 Aug 2010 23:40:00 +0200	[thread overview]
Message-ID: <4C76DF30.7080908@free.fr> (raw)

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

[PATCH] [AX25] missplaced sock_put(sk)

This patch moves a missplaced sock_put(sk) after
bh_unlock_sock(sk)
like in other parts of AX25 driver.

Signed-off-by: Bernard Pidoux <f6bvp@free.fr>






[-- Attachment #2: ax25_ds_timer.patch --]
[-- Type: text/x-patch, Size: 338 bytes --]

--- a/net/ax25/ax25_ds_timer.c	2010-08-26 23:36:45.000000000 +0200
+++ b/net/ax25/ax25_ds_timer.c	2010-08-26 19:55:13.000000000 +0200
@@ -112,8 +112,8 @@
 			if (sk) {
 				sock_hold(sk);
 				ax25_destroy_socket(ax25);
-				sock_put(sk);
 				bh_unlock_sock(sk);
+				sock_put(sk);
 			} else
 				ax25_destroy_socket(ax25);
 			return;

             reply	other threads:[~2010-08-26 21:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-26 21:40 Bernard F6BVP [this message]
2010-08-26 22:16 ` [PATCH] [AX25] missplaced sock_put(sk) David Miller
  -- strict thread matches above, loose matches on Subject: below --
2010-08-26 19:34 Bernard F6BVP
2010-08-26 21:09 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C76DF30.7080908@free.fr \
    --to=f6bvp@free.fr \
    --cc=bpidoux@free.fr \
    --cc=davem@davemloft.net \
    --cc=linux-hams@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.