From: Anthony Liguori <anthony@codemonkey.ws>
To: malc <av1474@comtv.ru>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Andreas Niederl <andreas.niederl@iaik.tugraz.at>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] Add TPM 1.2 host device passthrough interface
Date: Thu, 26 Aug 2010 16:57:59 -0500 [thread overview]
Message-ID: <4C76E367.6050100@codemonkey.ws> (raw)
In-Reply-To: <alpine.LNX.2.00.1008270137470.1495@linmac>
On 08/26/2010 04:44 PM, malc wrote:
>>
>>> and lastly there is no errx[1]
>>>
>>> [..snip..]
>>>
>>> [1] err(3):
>>> CONFORMING TO
>>> These functions are non-standard BSD extensions.
>>>
>> err() and errx() are already used somewhere. But these should be
>> converted to error_report etc., like other printf based local
>> functions.
>>
>>
> Only in Linux specific nbd code.
>
And the nbd stuff is derived from non-QEMU code that was brought into
the tree. It's generally a bad example of QEMU coding style.
Regards,
Anthony Liguori
prev parent reply other threads:[~2010-08-26 21:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 16:33 [Qemu-devel] [PATCH 1/3] Add TPM 1.2 host device passthrough interface Andreas Niederl
2010-08-25 16:33 ` [Qemu-devel] [PATCH 2/3] Add command line options for TPM interface Andreas Niederl
2010-08-25 19:15 ` Blue Swirl
2010-08-25 16:33 ` [Qemu-devel] [PATCH 3/3] seabios: Add DSDT entry for an emulated TPM 1.2 device Andreas Niederl
2010-08-25 16:46 ` [Qemu-devel] [PATCH 1/3] Add TPM 1.2 host device passthrough interface Anthony Liguori
2010-08-25 19:46 ` Blue Swirl
2010-08-25 20:46 ` malc
2010-08-26 17:22 ` Blue Swirl
2010-08-26 21:44 ` malc
2010-08-26 21:57 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C76E367.6050100@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=andreas.niederl@iaik.tugraz.at \
--cc=av1474@comtv.ru \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.