From: Christian Franke <Christian.Franke@t-online.de>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: Build fails due to wrong placement of -llibrary options
Date: Sat, 28 Aug 2010 21:02:49 +0200 [thread overview]
Message-ID: <4C795D59.6050402@t-online.de> (raw)
In-Reply-To: <AANLkTintNOoJRcN6ujm4WoGZpKqSUFMHH-YG9N2GcJvZ@mail.gmail.com>
BVK Chaitanya wrote:
> On Sat, Aug 28, 2010 at 5:53 PM, Christian Franke
> <...> wrote:
>
>> $ grep ^grub_bin2h_LD Makefile
>> grub_bin2h_LDADD = libgrub.a
>> grub_bin2h_LDFLAGS = $(AM_LDFLAGS) $(LDFLAGS_PROGRAM) $(LIBINTL)
>> $(LIBDEVMAPPER)
>>
>> The above should be:
>> grub_bin2h_LDADD = libgrub.a $(LIBINTL) $(LIBDEVMAPPER)
>> grub_bin2h_LDFLAGS = $(AM_LDFLAGS) $(LDFLAGS_PROGRAM)
>>
>> Same for all other utils. This likely needs to be fixed in gentpl.py.
>>
>>
> It is not necessary to modify gentpl.py, fixing in Makefile.util.def
> should be sufficient. Attached patch fixes all these AFAICS.
>
>
With the patch it works, thanks! Please apply.
--
Regards,
Christian Franke
prev parent reply other threads:[~2010-08-28 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-28 12:23 Build fails due to wrong placement of -llibrary options Christian Franke
2010-08-28 13:23 ` BVK Chaitanya
2010-08-28 13:35 ` BVK Chaitanya
2010-08-28 19:02 ` Christian Franke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C795D59.6050402@t-online.de \
--to=christian.franke@t-online.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.