Re: [PATCH v2] ncurses-5.7 : fix sdk build + add libtermcap link

["Eric Bénard" <eric@eukrea.com>]

Hi Enrico,

thanks for the review,

Le 29/08/2010 15:33, Enrico Scholz a écrit :
> Eric Bénard<eric@eukrea.com>  writes:
>
>> -        'narrowc --with-ticlib' \
>> -        'widec   --enable-widec --without-progs'; do
>> +        'narrowc  --with-ticlib' \
>> +        'widec    --with-ticlib --enable-widec --without-progs'; do
>
> can you place this in a separate patch please?
>
I'm not fully sure of this change, do you think this is needed or is 
this a mistake ?
>
>> +	cd ${D}${libdir}
>> +	ln -sf libncurses.so libtermcap.so
>> +	ln -sf libncurses.a libtermcap.a
>
> This part is wrong; libtermcap functionality is provided by libtinfo and
> does not need whole libncurses.
>
that's the way it's done on ubuntu so I thought this could be ok -but it 
seems there is no libtinfo on ubuntu which may explain this point), I 
will switch the link to libtinfo and test asterisk build.

>> +	ln -sf libncurses.so.5 libtermcap.so.5
>
> This is not needed; DL_NEEDED will be libtinfo.so.X both if you create a
> symlink or use the linkerscript.  There is nothing with a libtermcap.so.5
> SONAME either.
>
yes this was a test, I forget to remove this line sorry.

Eric