From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Oprt4-0006h8-V9 for mharc-grub-devel@gnu.org; Sun, 29 Aug 2010 20:06:10 -0400 Received: from [140.186.70.92] (port=54049 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oprt2-0006gt-5P for grub-devel@gnu.org; Sun, 29 Aug 2010 20:06:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oprt0-0008S3-Or for grub-devel@gnu.org; Sun, 29 Aug 2010 20:06:07 -0400 Received: from mail-bw0-f41.google.com ([209.85.214.41]:58474) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oprt0-0008Rr-HV for grub-devel@gnu.org; Sun, 29 Aug 2010 20:06:06 -0400 Received: by bwz6 with SMTP id 6so4456027bwz.0 for ; Sun, 29 Aug 2010 17:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=ErpngyY3hiJkW88doUqWAADtVSY6KfLkUJFuAncpwqw=; b=eYQ6nToYHqn15A2uf470+egq0P2bGDz4VsreUKqeoS+XTnfCs+VX2zBqNpUtXUyf/v 0H3FCExH6nhdUCcORlKlvPvGlyM1Py1zD1cljB+SkBLoFvf6HeaL6resn8UUPAdRF63l sx17tl1QBI6ks4Ee9J16U5AHUjnNeliC5BiY8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=QWQ0A4IxN1e8Xo9qV+8apwV9vASqSnbjc2C4On0HunRRN6ZUhk45jllxWlQmWDO7rm GjDj5qJAluG6vzE5veh4+MZSk/Kjd3mO80PBm46xfDHUBBegZdOoD6Yq/hEq5cSo4Ejk 6AGsx/vAz6WtsxO+PgI42kjN8hBMVIZpVcw3M= Received: by 10.204.51.3 with SMTP id b3mr2630587bkg.44.1283126765471; Sun, 29 Aug 2010 17:06:05 -0700 (PDT) Received: from debian.bg45.phnet (76-170.203-62.cust.bluewin.ch [62.203.170.76]) by mx.google.com with ESMTPS id s34sm4697326bkk.13.2010.08.29.17.06.03 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 29 Aug 2010 17:06:04 -0700 (PDT) Message-ID: <4C7AF5EA.5020305@gmail.com> Date: Mon, 30 Aug 2010 02:06:02 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100805 Icedove/3.0.6 MIME-Version: 1.0 To: grub-devel@gnu.org References: In-Reply-To: X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigE37E299746105F5A2C641CC8" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Bug report: PXE blocksize X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Aug 2010 00:06:09 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE37E299746105F5A2C641CC8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/27/2010 05:57 PM, Turner, Ian wrote: > Hello list, > > There seem to be a couple of problems with this variable: > > 1. The variable name in the code is pxe_blksize, whereas the info file = references net_pxe_blksize. > =20 Fixed. Thanks > 2. Changing the blocksize from within a config file which is itself sou= rced from TFTP breaks the transfer of the remainder of that file, because= grub_pxe_read() references the grub_pxe_blksize variable at each packet.= > =20 > Issue #2 can be resolved just by changing the grub_pxe_read() reference= to grub_pxe_blksize to reference data->block_size instead. > =20 I don't see where you mean. The only reference to pxe_blksize I see in pxefs_read is following: o.packet_size =3D grub_pxe_blksize; grub_pxe_call (GRUB_PXENV_TFTP_OPEN, &o); Which is called only when reopening file. Could you retry pulling? Now newreloc is merged into mainline so you can just pull mainline. > This is in the newreloc branch. > > Cheers, > > --Ian > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigE37E299746105F5A2C641CC8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAkx69eoACgkQNak7dOguQglWoAD9E2w6grJCx3+Yn4ubnnYLX4f5 NO7a4pOC7xjr24YG/i4A/3VJwwvoIqg5IXQSTEZJPgzBy6DziA4CBF0lAmT0Tc/y =AEmX -----END PGP SIGNATURE----- --------------enigE37E299746105F5A2C641CC8--