All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: Torsten Kaiser <just.for.lkml@googlemail.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] x86, setup: fix earlyprintk=serial,0x3f8,115200
Date: Sun, 29 Aug 2010 18:13:10 -0700	[thread overview]
Message-ID: <4C7B05A6.4010801@kernel.org> (raw)
In-Reply-To: <4C7B0578.8090807@kernel.org>


earlyprintk could take io port.

So we need to handle this case in setup code too, otherwise 0x3f8
will be treated as baud rate.

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 arch/x86/boot/early_serial_console.c |   14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

Index: linux-2.6/arch/x86/boot/early_serial_console.c
===================================================================
--- linux-2.6.orig/arch/x86/boot/early_serial_console.c
+++ linux-2.6/arch/x86/boot/early_serial_console.c
@@ -58,7 +58,19 @@ static void parse_earlyprintk(void)
 		if (arg[pos] == ',')
 			pos++;
 
-		if (!strncmp(arg + pos, "ttyS", 4)) {
+		/*
+		 * make sure we have
+		 *	"serial,0x3f8,115200"
+		 *	"serial,ttyS0,115200"
+		 *	"ttyS0,115200"
+		 */
+		if (pos == 7 && !strncmp(arg + pos, "0x", 2)) {
+			port = simple_strtoull(arg + pos, &e, 16);
+			if (port == 0 || arg + pos == e)
+				port = DEFAULT_SERIAL_PORT;
+			else
+				pos = e - arg;
+		} else if (!strncmp(arg + pos, "ttyS", 4)) {
 			static const int bases[] = { 0x3f8, 0x2f8 };
 			int idx = 0;
 

  reply	other threads:[~2010-08-30  1:14 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-29 17:25 Linux 2.6.36-rc3 Linus Torvalds
2010-08-29 19:24 ` Chris Ball
2010-08-29 19:24 ` Torsten Kaiser
2010-08-29 22:27   ` Yinghai Lu
2010-08-29 22:36     ` Yinghai Lu
2010-08-29 22:53   ` Yinghai Lu
2010-08-30  4:50     ` Torsten Kaiser
2010-08-30  1:12   ` [PATCH] x86, setup: fix earlyprintk=serial,ttyS0,115200 Yinghai Lu
2010-08-30  1:13     ` Yinghai Lu [this message]
2010-09-08 21:28       ` [PATCH] x86, setup: fix earlyprintk=serial,0x3f8,115200 H. Peter Anvin
2010-09-09  7:23         ` Yinghai Lu
2010-09-21 19:58       ` [tip:x86/urgent] x86, setup: Fix earlyprintk=serial,0x3f8,115200 tip-bot for Yinghai Lu
2010-09-21 19:58     ` [tip:x86/urgent] x86, setup: Fix earlyprintk=serial,ttyS0,115200 tip-bot for Yinghai Lu
2010-09-22 15:12       ` Early console confusion Bjorn Helgaas
2010-09-22 15:56         ` H. Peter Anvin
2010-09-22 16:44           ` Bjorn Helgaas
2010-09-22 16:53             ` H. Peter Anvin
2010-09-22 18:21               ` Bjorn Helgaas
2010-09-22 18:26                 ` H. Peter Anvin
2010-08-29 22:40 ` Linux 2.6.36-rc3 Jean-Denis Girard
2010-08-30  5:23   ` Borislav Petkov
2010-08-30  8:00     ` Jean-Denis Girard
2010-08-30  8:47 ` Miguel Calleja
2010-08-30 17:00   ` Suresh Jayaraman
2010-08-30 17:00     ` Suresh Jayaraman
     [not found]     ` <4C7BE3AE.8020204-l3A5Bk7waGM@public.gmane.org>
2010-08-30 17:14       ` Shirish Pargaonkar
2010-08-30 17:14         ` Shirish Pargaonkar
2010-08-30 17:25         ` Randy Dunlap
     [not found]           ` <20100830102527.17d5e1f1.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2010-08-30 21:27             ` Steve French
2010-08-30 21:27               ` Steve French
2010-08-30 19:28 ` Piotr Hosowicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C7B05A6.4010801@kernel.org \
    --to=yinghai@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=just.for.lkml@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.