From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Wolfgang_M=FCes?= Subject: Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors Date: Mon, 30 Aug 2010 08:51:37 +0200 Message-ID: <4C7B54F9.6090200@auerswald.de> References: <9535dc8dfe4476a0314b9513fb9d37862faa731d.1267209149.git.nicolas.ferre@atmel.com> <20100827193303.GB23079@void.printf.net> <20100827193457.GC23079@void.printf.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from fw2.winet.de ([84.17.96.48]:59268 "EHLO fw2.winet.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751565Ab0H3HJs convert rfc822-to-8bit (ORCPT ); Mon, 30 Aug 2010 03:09:48 -0400 Received: from mr03.winet.de (localhost [127.0.0.1]) by fw2.winet.de (Postfix) with ESMTP id 55C64465EBC for ; Mon, 30 Aug 2010 08:51:39 +0200 (CEST) Received: from smtp03.winet.de (mr03.winet.de [192.168.12.13]) by mr03.winet.de (Postfix) with ESMTP id 0790A465EF4 for ; Mon, 30 Aug 2010 08:51:38 +0200 (CEST) Received: from mail.auerswald.de (unknown [212.185.163.229]) by smtp03.winet.de (Postfix) with ESMTP id AE4CA465EBC for ; Mon, 30 Aug 2010 08:51:38 +0200 (CEST) In-Reply-To: <20100827193457.GC23079@void.printf.net> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Chris Ball Cc: Nicolas Ferre , akpm@linux-foundation.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, avictor.za@gmail.com Hi, Am 27.08.2010 21:34, schrieb Chris Ball: > On Fri, Aug 27, 2010 at 08:33:03PM +0100, Chris Ball wrote: >> Looks like only the first half of this patch was applied? The >> kunmap_atomic() line is still present as before in Linus' tree. It was argued that the kunmap_atomic() will truncate the pointer to the= =20 start of the page anyway, so the subtraction is not needed. best regards i. A. Wolfgang Muees Hardware-Entwicklung Leiter Pruefen & Layout --=20 Auerswald Gesellschaft fuer Datensysteme mbH Phone: +49 5306-9219-562 =46ax: +49 5306-9200-94 -------------------------------------------------------------- Auerswald Gesellschaft fuer Datensysteme mbH, Vor den Grashoefen 1, 38162 Cremlingen Registriert beim AG Braunschweig HRB 7499 Gesch=E4ftsf=FChrer: Dipl-Ing. Gerhard Auerswald From mboxrd@z Thu Jan 1 00:00:00 1970 From: wolfgang.mues@auerswald.de (=?ISO-8859-1?Q?Wolfgang_M=FCes?=) Date: Mon, 30 Aug 2010 08:51:37 +0200 Subject: [PATCH 1/7] mmc: at91_mci: fix pointer errors In-Reply-To: <20100827193457.GC23079@void.printf.net> References: <9535dc8dfe4476a0314b9513fb9d37862faa731d.1267209149.git.nicolas.ferre@atmel.com> <20100827193303.GB23079@void.printf.net> <20100827193457.GC23079@void.printf.net> Message-ID: <4C7B54F9.6090200@auerswald.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Am 27.08.2010 21:34, schrieb Chris Ball: > On Fri, Aug 27, 2010 at 08:33:03PM +0100, Chris Ball wrote: >> Looks like only the first half of this patch was applied? The >> kunmap_atomic() line is still present as before in Linus' tree. It was argued that the kunmap_atomic() will truncate the pointer to the start of the page anyway, so the subtraction is not needed. best regards i. A. Wolfgang Muees Hardware-Entwicklung Leiter Pruefen & Layout -- Auerswald Gesellschaft fuer Datensysteme mbH Phone: +49 5306-9219-562 Fax: +49 5306-9200-94 -------------------------------------------------------------- Auerswald Gesellschaft fuer Datensysteme mbH, Vor den Grashoefen 1, 38162 Cremlingen Registriert beim AG Braunschweig HRB 7499 Gesch?ftsf?hrer: Dipl-Ing. Gerhard Auerswald From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753481Ab0H3HJu (ORCPT ); Mon, 30 Aug 2010 03:09:50 -0400 Received: from fw2.winet.de ([84.17.96.48]:59269 "EHLO fw2.winet.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752808Ab0H3HJs convert rfc822-to-8bit (ORCPT ); Mon, 30 Aug 2010 03:09:48 -0400 Message-ID: <4C7B54F9.6090200@auerswald.de> Date: Mon, 30 Aug 2010 08:51:37 +0200 From: =?ISO-8859-1?Q?Wolfgang_M=FCes?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.2.7) Gecko/20100713 Lightning/1.0b2 Thunderbird/3.1.1 MIME-Version: 1.0 To: Chris Ball CC: Nicolas Ferre , , , , , Subject: Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors References: <9535dc8dfe4476a0314b9513fb9d37862faa731d.1267209149.git.nicolas.ferre@atmel.com> <20100827193303.GB23079@void.printf.net> <20100827193457.GC23079@void.printf.net> In-Reply-To: <20100827193457.GC23079@void.printf.net> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am 27.08.2010 21:34, schrieb Chris Ball: > On Fri, Aug 27, 2010 at 08:33:03PM +0100, Chris Ball wrote: >> Looks like only the first half of this patch was applied? The >> kunmap_atomic() line is still present as before in Linus' tree. It was argued that the kunmap_atomic() will truncate the pointer to the start of the page anyway, so the subtraction is not needed. best regards i. A. Wolfgang Muees Hardware-Entwicklung Leiter Pruefen & Layout -- Auerswald Gesellschaft fuer Datensysteme mbH Phone: +49 5306-9219-562 Fax: +49 5306-9200-94 -------------------------------------------------------------- Auerswald Gesellschaft fuer Datensysteme mbH, Vor den Grashoefen 1, 38162 Cremlingen Registriert beim AG Braunschweig HRB 7499 Geschäftsführer: Dipl-Ing. Gerhard Auerswald