All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] Re: [PATCH v3] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode
Date: Mon, 30 Aug 2010 15:59:59 +0200	[thread overview]
Message-ID: <4C7BB95F.8070509@redhat.com> (raw)
In-Reply-To: <4C7BB5F7.6010906@codemonkey.ws>

On 08/30/10 15:45, Anthony Liguori wrote:
> On 08/30/2010 08:11 AM, Jes Sorensen wrote:
>> If you run in -M pc-0.11 or older option ROMs are provided via fw_cfg,
>> which means QEMU is unable to load it after boot time if you try to
>> hot-plug a new network device via the monitor. Instead it decides to
>> exit with an error.
>>    
> 
> Which network device?
> 
> Take a look at ne2k.c's rom loading.  It's got logic for rom loading
> with hotplug but e1000 and rtl8139 don't.  Maybe it's because ne2k also
> supports an ISA mode?

It happens with virtio-net as well which is where I saw it first.
However, it's really only an issue in compat mode since with 0.12
onwards we can load option ROMs on the fly.

Cheers,
Jes

  parent reply	other threads:[~2010-08-30 14:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-30  8:16 [Qemu-devel] [PATCH v3] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode Jes.Sorensen
2010-08-30 13:00 ` [Qemu-devel] " Anthony Liguori
2010-08-30 13:11   ` Jes Sorensen
2010-08-30 13:45     ` Anthony Liguori
2010-08-30 13:57       ` Gerd Hoffmann
2010-08-30 13:59       ` Jes Sorensen [this message]
2010-08-30 13:29   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C7BB95F.8070509@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.