From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] UEC: Don't udelay needlessly
Date: Mon, 30 Aug 2010 23:01:22 -0700 [thread overview]
Message-ID: <4C7C9AB2.3000602@gmail.com> (raw)
In-Reply-To: <1281519862-27858-1-git-send-email-Joakim.Tjernlund@transmode.se>
Hi Jocke,
On 8/11/2010 2:44 AM, Joakim Tjernlund wrote:
> uec_init() adds an udelay(100000) even though
> the PHY status read went well, don't do that.
>
> Signed-off-by: Joakim Tjernlund<Joakim.Tjernlund@transmode.se>
> ---
> drivers/qe/uec.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/qe/uec.c b/drivers/qe/uec.c
> index ccbf27d..758151f 100644
> --- a/drivers/qe/uec.c
> +++ b/drivers/qe/uec.c
> @@ -1223,8 +1223,10 @@ static int uec_init(struct eth_device* dev, bd_t *bd)
> i = 50;
> do {
> err = curphy->read_status(uec->mii_info);
> + if (!(((i--> 0)&& !uec->mii_info->link) || err))
> + break;
> udelay(100000);
> - } while (((i--> 0)&& !uec->mii_info->link) || err);
> + } while (1);
>
> if (err || i<= 0)
> printf("warning: %s: timeout on PHY link\n", dev->name);
Parts 1 & 2 applied to net/next. Sorry for taking so long.
regards,
Ben
prev parent reply other threads:[~2010-08-31 6:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 9:44 [U-Boot] [PATCH 1/2] UEC: Don't udelay needlessly Joakim Tjernlund
2010-08-11 9:44 ` [U-Boot] [PATCH 2/2] UEC PHY: Remove strange 0.5 sec delay Joakim Tjernlund
2010-08-12 5:17 ` Kim Phillips
2010-08-12 6:11 ` Joakim Tjernlund
2010-08-18 7:30 ` Joakim Tjernlund
2010-08-18 7:29 ` Joakim Tjernlund
2010-08-12 5:16 ` [U-Boot] [PATCH 1/2] UEC: Don't udelay needlessly Kim Phillips
2010-08-18 7:28 ` Joakim Tjernlund
2010-08-18 7:55 ` Wolfgang Denk
2010-08-23 5:53 ` Ben Warren
2010-08-31 6:01 ` Ben Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7C9AB2.3000602@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.