Latest base.bbclass commit breaks meta-toolchain build

Latest base.bbclass commit breaks meta-toolchain build

[Holger Freyther]

Hi,

with the latest change the task-host-sdk.bb tries to copy it on itself and cp
breaks. Reverting the commit has fixed the issue for me. Years ago pb_ added a
"safe" append path function, I think it could make sense to use it here as well?

Re: Latest base.bbclass commit breaks meta-toolchain build

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 31-08-10 09:53, Holger Freyther wrote:
> Hi,
> 
> with the latest change the task-host-sdk.bb tries to copy it on itself and cp
> breaks. Reverting the commit has fixed the issue for me.

The tinderbox as work is turning red as well for tasks and images ('cp:
foo.bb and foo.bb are the same file') and reverting this change seems to
make it work again.

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMfMotMkyGM64RGpERAmTjAJoCAsOvd9YXTsXLWYNk82d8KEloRwCgilez
O3ez/SlE2kAuDHUWJ8dSWAI=
=awDo
-----END PGP SIGNATURE-----

Re: Latest base.bbclass commit breaks meta-toolchain build

[Chris Larson]

On Tue, Aug 31, 2010 at 2:23 AM, Koen Kooi <k.kooi@student.utwente.nl>wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 31-08-10 09:53, Holger Freyther wrote:
> > Hi,
> >
> > with the latest change the task-host-sdk.bb tries to copy it on itself
> and cp
> > breaks. Reverting the commit has fixed the issue for me.
>
> The tinderbox as work is turning red as well for tasks and images ('cp:
> foo.bb and foo.bb are the same file') and reverting this change seems to
> make it work again.
>

This makes no sense -- something must be making some really foolish
assumptions somewhere.  Reverted for now, we're back to having broken
absolute file:// uris again.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

Re: Latest base.bbclass commit breaks meta-toolchain build

[Chris Larson]

On Tue, Aug 31, 2010 at 12:53 AM, Holger Freyther
<holger+oe@freyther.de<holger%2Boe@freyther.de>
> wrote:

> with the latest change the task-host-sdk.bb tries to copy it on itself and
> cp
> breaks. Reverting the commit has fixed the issue for me. Years ago pb_
> added a
> "safe" append path function, I think it could make sense to use it here as
> well?
>

I think you misunderstood.  The latest base.bbclass changed oe_unpack_file
to use pb's path join function, and that's what caused the breakage.
Previously it was using os.path.join.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics