Re: [PATCH] Fix bootloader handling when empty string is being output

[Michal Novotny <minovotn@redhat.com>]

On 08/31/2010 12:10 PM, Ian Campbell wrote:
> On Tue, 2010-08-31 at 11:00 +0100, Michal Novotny wrote:
>    
>> I don't know how it's
>> working with upstream version since I found out that syntax like `xm
>> create -c PVguest` with default settings (pyGrub bootloader) doesn't
>> show the pyGrub at all so I don't know what's wrong with my setup. I'm
>> using 2.6.32.15-xen kernel/hypervisor version with latest unstable
>> user-space tools.
>>
>> Any hint how this should be working Ian?
>>      
> It should be working as you expect, e.g. "xm create -c xxx" should show
> you the pygrub output, unless you have used something like "--entry=x"
> or "-q" which disable interactive mode in your bootloader_args.
>
> I'm afraid I don't know what is broken, I'm reasonably sure it was
> working for me when I developed libxl_bootloader.c since I was comparing
> the two.
>
> Ian.
>
>    
No Ian, it's not working. The config file is having:
...
bootloader = "/usr/bin/pygrub"
...
So it should show the pyGrub ncurses screen, right? But it doesn't show 
anything on version cloned from git yesterday. Any ideas what may be 
wrong? Maybe a configuration file should be somewhat different, I don't 
know but this is working fine to get the data from image - it just 
doesn't show the ncurses pyGrub screen. Isn't it possible this is 
somehow connected to the PTY patch ? How should the PTY c/s 13540 ? This 
is the rewrite that was there and honestly I don't remember whether I 
tried to run `xm create -c PVguest` on upstream Xen-4.1 ever so I don't 
know. Isn't it hypervisor/kernel related that it requires some data that 
are not coming from there?

Thanks,
Michal

-- 
Michal Novotny<minovotn@redhat.com>, RHCE
Virtualization Team (xen userspace), Red Hat