From: Randy Dunlap <randy.dunlap@oracle.com>
To: Masayuki Ohtake <masa-korg@dsn.okisemi.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
Sam Ravnborg <sam@ravnborg.org>, Joe Perches <joe@perches.com>,
LKML <linux-kernel@vger.kernel.org>,
ML netdev <netdev@vger.kernel.org>,
Greg Rose <gregory.v.rose@intel.com>,
Maxime Bizon <mbizon@freebox.fr>,
Kristoffer Glembo <kristoffer@gaisler.com>,
Ralf Baechle <ralf@linux-mips.org>,
John Linn <john.linn@xilinx.com>,
"David S. Miller" <davem@davemloft.net>,
MeeGo <meego-dev@meego.com>, "Wang, Qi" <qi.wang@intel.com>,
"Wang, Yong Y" <yong.y.wang@intel.com>,
Andrew <andrew.chih.howe.khor@intel.com>,
Intel OTC <joel.clark@intel.com>,
"Foster, Margie" <margie.foster@intel.com>,
Toshiharu Okada <okada533@dsn.okisemi.com>,
Tomoya Morinaga <morinaga526@dsn.okisemi.com>,
Takahiro Shimizu <shimizu394@dsn.okisemi.com>
Subject: Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH
Date: Tue, 31 Aug 2010 08:08:06 -0700 [thread overview]
Message-ID: <4C7D1AD6.3080005@oracle.com> (raw)
In-Reply-To: <4C7D0E7A.5060309@dsn.okisemi.com>
On 08/31/10 07:15, Masayuki Ohtake wrote:
>
> Hi Sam, Joe and Stephen
>
> Thank you for your comments.
> We have modified this driver for your comment.
>
> ---
> Gigabit Ethernet driver of Topcliff PCH
> Patch created against 2.6.35
>
> Topcliff PCH is the platform controller hub that is going to be used in
> Intel's upcoming general embedded platform. All IO peripherals in
> Topcliff PCH are actually devices sitting on AMBA bus.
> Topcliff PCH has Gigabit Ethernet I/F. Using this I/F, it is able to
> access system devices connected to Gigabit Ethernet.
>
> Signed-off-by: Masayuki Ohtake <masa-korg@dsn.okisemi.com>
> ---
> drivers/net/Kconfig | 10 +
> drivers/net/Makefile | 1 +
> drivers/net/pch_gbe/Makefile | 4 +
> drivers/net/pch_gbe/pch_gbe.h | 683 +++++++++
> drivers/net/pch_gbe/pch_gbe_api.c | 246 ++++
> drivers/net/pch_gbe/pch_gbe_api.h | 34 +
> drivers/net/pch_gbe/pch_gbe_ethtool.c | 618 ++++++++
> drivers/net/pch_gbe/pch_gbe_main.c | 2591 +++++++++++++++++++++++++++++++++
> drivers/net/pch_gbe/pch_gbe_param.c | 519 +++++++
> drivers/net/pch_gbe/pch_gbe_phy.c | 276 ++++
> drivers/net/pch_gbe/pch_gbe_phy.h | 35 +
> 11 files changed, 5017 insertions(+), 0 deletions(-)
> create mode 100644 drivers/net/pch_gbe/Makefile
> create mode 100644 drivers/net/pch_gbe/pch_gbe.h
> create mode 100644 drivers/net/pch_gbe/pch_gbe_api.c
> create mode 100644 drivers/net/pch_gbe/pch_gbe_api.h
> create mode 100644 drivers/net/pch_gbe/pch_gbe_ethtool.c
> create mode 100644 drivers/net/pch_gbe/pch_gbe_main.c
> create mode 100644 drivers/net/pch_gbe/pch_gbe_param.c
> create mode 100644 drivers/net/pch_gbe/pch_gbe_phy.c
> create mode 100644 drivers/net/pch_gbe/pch_gbe_phy.h
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 2decc59..f8102de 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2004,6 +2004,16 @@ menuconfig NETDEV_1000
> If you say N, all options in this submenu will be skipped and disabled.
>
> if NETDEV_1000
> +config PCH_GBE
> + tristate "PCH Gigabit Ethernet"
> + depends on PCI
IMO it's not nice to list this driver before others that are already there.
> + ---help---
> + This is an gigabit ethernet driver for Topcliff PCH.
This is a gigabit
You aren't going to modify this text after the product is released, are you?
Might as well make it better now:
> + Topcliff PCH is the platform controller hub that is going to be used
Topcliff PCH is the platform controller hub that is used in Intel's
general embedded platform.
> + in Intel's upcoming general embedded platform.
> + Topcliff PCH has Gigabit Ethernet I/F. Using this I/F, it is able to
Change "I/F" to "interface".
> + access system devices connected to Gigabit Ethernet.
> + This driver enables Gigabit Ethernet function.
>
> config ACENIC
> tristate "Alteon AceNIC/3Com 3C985/NetGear GA620 Gigabit support"
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-08-31 15:08 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 9:56 [PATCH] Gigabit Ethernet driver of Topcliff PCH Masayuki Ohtake
2010-08-26 9:56 ` Masayuki Ohtake
2010-08-26 10:28 ` Sam Ravnborg
2010-08-26 12:47 ` Masayuki Ohtake
2010-08-26 14:44 ` Joe Perches
2010-08-26 15:34 ` Stephen Hemminger
2010-08-26 15:40 ` Stephen Hemminger
2010-08-26 15:41 ` Stephen Hemminger
2010-08-26 15:42 ` Stephen Hemminger
2010-08-26 15:43 ` Stephen Hemminger
2010-08-26 15:45 ` Stephen Hemminger
2010-08-26 15:47 ` Stephen Hemminger
2010-08-26 15:57 ` Stephen Hemminger
2010-08-26 16:05 ` Stephen Hemminger
2010-08-26 16:16 ` Joe Perches
2010-08-26 16:29 ` Stephen Hemminger
2010-08-26 17:02 ` Joe Perches
2010-08-31 14:15 ` Masayuki Ohtake
2010-08-31 14:15 ` Masayuki Ohtake
2010-08-31 14:51 ` Eric Dumazet
2010-09-02 12:39 ` Masayuki Ohtake
2010-09-02 13:40 ` Eric Dumazet
2010-09-02 15:10 ` Stephen Hemminger
2010-09-03 13:32 ` Masayuki Ohtake
2010-09-03 13:43 ` Eric Dumazet
2010-09-03 14:11 ` Masayuki Ohtake
2010-08-31 15:08 ` Randy Dunlap [this message]
2010-08-31 16:10 ` Joe Perches
2010-08-31 17:25 ` [PATCH] drivers/net/pch_gbe: Use bool not unsigned char Joe Perches
2010-08-31 18:38 ` [PATCH] drivers/net/pch_gbe: Cleanup stats use Joe Perches
2010-09-01 1:33 ` Stephen Hemminger
2010-09-01 1:38 ` Joe Perches
2010-09-03 2:23 ` [PATCH] Gigabit Ethernet driver of Topcliff PCH FUJITA Tomonori
2010-09-07 1:13 ` Masayuki Ohtake
2010-09-07 3:21 ` FUJITA Tomonori
2010-09-07 4:06 ` Masayuki Ohtake
-- strict thread matches above, loose matches on Subject: below --
2010-09-03 14:09 Masayuki Ohtake
2010-09-03 14:09 ` Masayuki Ohtake
2010-09-03 16:35 ` Jiri Slaby
2010-09-07 1:13 ` Masayuki Ohtake
2010-09-08 13:52 ` Masayuki Ohtake
2010-09-08 14:16 ` Jiri Slaby
2010-09-08 14:54 ` Stephen Hemminger
2010-09-08 14:55 ` Stephen Hemminger
2010-09-09 13:37 ` Masayuki Ohtake
2010-09-09 13:38 ` Masayuki Ohtake
2010-09-03 20:00 ` Joe Perches
2010-09-07 2:42 ` Masayuki Ohtake
2010-09-07 2:42 ` Masayuki Ohtake
2010-09-08 20:36 ` David Miller
2010-09-15 12:19 ` Masayuki Ohtake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7D1AD6.3080005@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=andrew.chih.howe.khor@intel.com \
--cc=davem@davemloft.net \
--cc=gregory.v.rose@intel.com \
--cc=joe@perches.com \
--cc=joel.clark@intel.com \
--cc=john.linn@xilinx.com \
--cc=kristoffer@gaisler.com \
--cc=linux-kernel@vger.kernel.org \
--cc=margie.foster@intel.com \
--cc=masa-korg@dsn.okisemi.com \
--cc=mbizon@freebox.fr \
--cc=meego-dev@meego.com \
--cc=morinaga526@dsn.okisemi.com \
--cc=netdev@vger.kernel.org \
--cc=okada533@dsn.okisemi.com \
--cc=qi.wang@intel.com \
--cc=ralf@linux-mips.org \
--cc=sam@ravnborg.org \
--cc=shemminger@vyatta.com \
--cc=shimizu394@dsn.okisemi.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.