diff for duplicates of <4C7D247F.4060500@bfs.de> diff --git a/a/1.txt b/N1/1.txt index 7f9a8c7..58b817e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -25,7 +25,7 @@ Julia Lawall schrieb: > |of_match_node > )(...); > ... -> if (x = NULL) S +> if (x == NULL) S > <... when != x = E > *if (...) { > ... when != of_node_put(x) @@ -51,11 +51,11 @@ Julia Lawall schrieb: > --- a/drivers/macintosh/via-pmu-led.c > +++ b/drivers/macintosh/via-pmu-led.c > @@ -92,8 +92,10 @@ static int __init via_pmu_led_init(void) -> if (dt = NULL) +> if (dt == NULL) > return -ENODEV; > model = of_get_property(dt, "model", NULL); -> - if (model = NULL) -> + if (model = NULL) { +> - if (model == NULL) +> + if (model == NULL) { > + of_node_put(dt); > return -ENODEV; > + } diff --git a/a/content_digest b/N1/content_digest index 78b60f9..0329171 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,15 +1,13 @@ "ref\01283075566-27441-1-git-send-email-julia@diku.dk\0" "ref\01283075566-27441-2-git-send-email-julia@diku.dk\0" "From\0walter harms <wharms@bfs.de>\0" - "Subject\0Re: [PATCH 1/7] drivers/macintosh/via-pmu-led.c: Add of_node_put\0" - "Date\0Tue, 31 Aug 2010 15:49:19 +0000\0" + "Subject\0Re: [PATCH 1/7] drivers/macintosh/via-pmu-led.c: Add of_node_put to avoid memory leak\0" + "Date\0Tue, 31 Aug 2010 17:49:19 +0200\0" "To\0Julia Lawall <julia@diku.dk>\0" - "Cc\0Benjamin Herrenschmidt <benh@kernel.crashing.org>" + "Cc\0devicetree-discuss@lists.ozlabs.org" kernel-janitors@vger.kernel.org - Grant Likely <grant.likely@secretlab.ca> - linuxppc-dev@lists.ozlabs.org linux-kernel@vger.kernel.org - " devicetree-discuss@lists.ozlabs.org\0" + " linuxppc-dev@lists.ozlabs.org\0" "\00:1\0" "b\0" "\n" @@ -39,7 +37,7 @@ "> |of_match_node\n" "> )(...);\n" "> ...\n" - "> if (x = NULL) S\n" + "> if (x == NULL) S\n" "> <... when != x = E\n" "> *if (...) {\n" "> ... when != of_node_put(x)\n" @@ -65,11 +63,11 @@ "> --- a/drivers/macintosh/via-pmu-led.c\n" "> +++ b/drivers/macintosh/via-pmu-led.c\n" "> @@ -92,8 +92,10 @@ static int __init via_pmu_led_init(void)\n" - "> \tif (dt = NULL)\n" + "> \tif (dt == NULL)\n" "> \t\treturn -ENODEV;\n" "> \tmodel = of_get_property(dt, \"model\", NULL);\n" - "> -\tif (model = NULL)\n" - "> +\tif (model = NULL) {\n" + "> -\tif (model == NULL)\n" + "> +\tif (model == NULL) {\n" "> +\t\tof_node_put(dt);\n" "> \t\treturn -ENODEV;\n" "> +\t}\n" @@ -84,4 +82,4 @@ "re,\n" wh -e6a0fc563ca9c63cfc8a80039f05147b9408b54103ec3e2e0347af7170c7a5b4 +8338297786b8aa7eb1906bf44ec72b7b2f4096d217d3c3826e349cd395db99a9
diff --git a/a/1.txt b/N2/1.txt index 7f9a8c7..58b817e 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -25,7 +25,7 @@ Julia Lawall schrieb: > |of_match_node > )(...); > ... -> if (x = NULL) S +> if (x == NULL) S > <... when != x = E > *if (...) { > ... when != of_node_put(x) @@ -51,11 +51,11 @@ Julia Lawall schrieb: > --- a/drivers/macintosh/via-pmu-led.c > +++ b/drivers/macintosh/via-pmu-led.c > @@ -92,8 +92,10 @@ static int __init via_pmu_led_init(void) -> if (dt = NULL) +> if (dt == NULL) > return -ENODEV; > model = of_get_property(dt, "model", NULL); -> - if (model = NULL) -> + if (model = NULL) { +> - if (model == NULL) +> + if (model == NULL) { > + of_node_put(dt); > return -ENODEV; > + } diff --git a/a/content_digest b/N2/content_digest index 78b60f9..4de2f4c 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,8 +1,8 @@ "ref\01283075566-27441-1-git-send-email-julia@diku.dk\0" "ref\01283075566-27441-2-git-send-email-julia@diku.dk\0" "From\0walter harms <wharms@bfs.de>\0" - "Subject\0Re: [PATCH 1/7] drivers/macintosh/via-pmu-led.c: Add of_node_put\0" - "Date\0Tue, 31 Aug 2010 15:49:19 +0000\0" + "Subject\0Re: [PATCH 1/7] drivers/macintosh/via-pmu-led.c: Add of_node_put to avoid memory leak\0" + "Date\0Tue, 31 Aug 2010 17:49:19 +0200\0" "To\0Julia Lawall <julia@diku.dk>\0" "Cc\0Benjamin Herrenschmidt <benh@kernel.crashing.org>" kernel-janitors@vger.kernel.org @@ -39,7 +39,7 @@ "> |of_match_node\n" "> )(...);\n" "> ...\n" - "> if (x = NULL) S\n" + "> if (x == NULL) S\n" "> <... when != x = E\n" "> *if (...) {\n" "> ... when != of_node_put(x)\n" @@ -65,11 +65,11 @@ "> --- a/drivers/macintosh/via-pmu-led.c\n" "> +++ b/drivers/macintosh/via-pmu-led.c\n" "> @@ -92,8 +92,10 @@ static int __init via_pmu_led_init(void)\n" - "> \tif (dt = NULL)\n" + "> \tif (dt == NULL)\n" "> \t\treturn -ENODEV;\n" "> \tmodel = of_get_property(dt, \"model\", NULL);\n" - "> -\tif (model = NULL)\n" - "> +\tif (model = NULL) {\n" + "> -\tif (model == NULL)\n" + "> +\tif (model == NULL) {\n" "> +\t\tof_node_put(dt);\n" "> \t\treturn -ENODEV;\n" "> +\t}\n" @@ -84,4 +84,4 @@ "re,\n" wh -e6a0fc563ca9c63cfc8a80039f05147b9408b54103ec3e2e0347af7170c7a5b4 +e901c0206559146d28aff9de9fb90307bdf6e057ac68e3ef3e936508b1e37eb5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.