From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56932 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OqTbt-0006V4-P6 for qemu-devel@nongnu.org; Tue, 31 Aug 2010 12:22:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OqTbs-0007MI-Fm for qemu-devel@nongnu.org; Tue, 31 Aug 2010 12:22:57 -0400 Received: from mail-vw0-f45.google.com ([209.85.212.45]:63695) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OqTbs-0007MC-CD for qemu-devel@nongnu.org; Tue, 31 Aug 2010 12:22:56 -0400 Received: by vws19 with SMTP id 19so5747298vws.4 for ; Tue, 31 Aug 2010 09:22:55 -0700 (PDT) Message-ID: <4C7D2C4B.3020205@codemonkey.ws> Date: Tue, 31 Aug 2010 11:22:35 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v5 00/10] initial spice support. References: <1283265148-15977-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1283265148-15977-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On 08/31/2010 09:32 AM, Gerd Hoffmann wrote: > Hi, > > Here comes v5 of the iniial spice support patch series. > Reviewed-by: Anthony Liguori For the whole series. Once folks have gotten a chance to review it a day or two more, I'll pull the repo if there are no issues. Regards, Anthony Liguori > * Detect spice in configure, Makefile windup. > * Support for keyboard, mouse and tablet. > * Support for simple display output (works as DisplayChangeListener, > plays with any gfx card, sends simple draw commands to update > dirty regions). > > Note that this patch series does *not* yet contain the qxl paravirtual > gfx card. That will come as part of a additional patch series after > sorting the vgabios support. > > The patches are also available in the git repository at: > git://anongit.freedesktop.org/spice/qemu submit.5 > > Changes since v4: > * Code style fixups. > * Small bug fix (display_remote not being set when configuring > spice via config file). > > Changes since v3: > * Drop global spice_server variable, provide a thin wrapper function > instead so spice interfaces can be registered without needing > spice_server. > * Update locking comments. > > Changes since v2: > * Add copyright headers to the files. > * Add dprint for debug logging. > * Add mapping for buttons and leds. > * Add comments for locking+threads. > * Drop includes which qemu-common.h brings in. > * Compile -spice switch unconditionally. > * Hook up spice init using module.h, drop #ifdefs. > * Misc minor tweaks. > > > *** BLURB HERE *** > > Gerd Hoffmann (10): > Use display types for local display only. > Use machine_init() to register virtfs config options. > add pflib: PixelFormat conversion library. > configure: add logging > add spice into the configure file > spice: core bits > spice: add keyboard > spice: add mouse > spice: simple display > spice: add tablet support > > Makefile.objs | 3 + > configure | 42 +++++- > fsdev/qemu-fsdev.c | 9 + > pflib.c | 213 +++++++++++++++++++++++++++ > pflib.h | 20 +++ > qemu-config.c | 18 +++ > qemu-config.h | 1 + > qemu-options.hx | 21 +++ > sysemu.h | 1 - > ui/qemu-spice.h | 41 +++++ > ui/spice-core.c | 189 ++++++++++++++++++++++++ > ui/spice-display.c | 412 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > ui/spice-display.h | 69 +++++++++ > ui/spice-input.c | 217 +++++++++++++++++++++++++++ > vl.c | 50 +++++-- > 15 files changed, 1287 insertions(+), 19 deletions(-) > create mode 100644 pflib.c > create mode 100644 pflib.h > create mode 100644 ui/qemu-spice.h > create mode 100644 ui/spice-core.c > create mode 100644 ui/spice-display.c > create mode 100644 ui/spice-display.h > create mode 100644 ui/spice-input.c > > >