From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] Write to read-only msr MSR_IA32_PERF_STATUS is harmless, ignore it!
Date: Tue, 31 Aug 2010 19:04:23 +0200 [thread overview]
Message-ID: <4C7D3617.5060804@redhat.com> (raw)
In-Reply-To: <4C7D3166.30702@redhat.com>
On 08/31/10 18:44, Avi Kivity wrote:
> On 08/31/2010 07:33 PM, Jes Sorensen wrote:
>> On 08/31/10 18:28, Avi Kivity wrote:
>>> On 08/31/2010 03:17 PM, Jes.Sorensen@redhat.com wrote:
>>>> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>>>>
>>>> We regularly see bug reports over this one, however it is a write to
>>>> a read-only register which some operating systems (including Linux)
>>>> tend to write to once in a while.
>>>>
>>>> Ignore the writes since they do no harm.
>>>>
>>> Does Linux write it with wrmsr_safe()? If not, I don't see how it
>>> works. If it does, then we shouldn't ignore the write, instead issue
>>> the #GP as usual, but be silent about it.
>> To be honest, I am having a hard time determining where the write
>> happens. I looked at this with Gleb and the rip obtained by
>> kvm_read_rip(vcpu) in the code doesn't indicate anything that resembles
>> a wrmsr().
>>
>> It was either a
>> 560 outb(0xfe, 0x64); /* pulse reset low */
>> or
>> 49 asm volatile("sti; hlt": : :"memory");
>>
>> which makes no sense to me,
>
> Just grep for the msr name in a guest kernel source that's known to
> trigger the message.
Been there, done that! This happens with an F13 kernel during reboot.
Ran the search on the expanded 2.6.32.8-149 tree and found no reference
to anything trying to write it, except for KVM backing up the flag, but
that shouldn't happen in the guest.
>> but given it's x86, I am not sure if it
>> could have come from the BIOS or something during reboot?
>
> The bios is the same for all kernels (and is unlikely to mess with
> performance counter msrs anyway).
I was fooled by this too, it's not a performance counter MSR, it's a CPU
frequency scaling MSR.
Cheers,
Jes
next prev parent reply other threads:[~2010-08-31 17:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 12:17 [PATCH] Write to read-only msr MSR_IA32_PERF_STATUS is harmless, ignore it! Jes.Sorensen
2010-08-31 16:28 ` Avi Kivity
2010-08-31 16:33 ` Jes Sorensen
2010-08-31 16:44 ` Avi Kivity
2010-08-31 17:04 ` Jes Sorensen [this message]
2010-08-31 20:00 ` David S. Ahern
2010-08-31 20:02 ` Marcelo Tosatti
2010-09-01 7:37 ` Avi Kivity
2010-09-01 8:42 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7D3617.5060804@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.