All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Gwendal Grignou <gwendal@google.com>
Cc: tj@kernel.org, nicolas@jungers.net, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata-sff: Reenable Port Multiplier after libata-sff remodeling.
Date: Tue, 31 Aug 2010 19:32:24 -0400	[thread overview]
Message-ID: <4C7D9108.5010506@garzik.org> (raw)
In-Reply-To: <1283296836-23863-1-git-send-email-gwendal@google.com>

On 08/31/2010 07:20 PM, Gwendal Grignou wrote:
> Keep track of the link on the which the current request is in progress.
> It allows support of links behind port multiplier.
>
> Not all libata-sff is PMP compliant. Code for native BMDMA controller
> does not take in accound PMP.
>
> Tested on Marvell 7042 and Sil7526.
>
> Signed-off-by: Gwendal Grignou<gwendal@google.com>
> ---
>   drivers/ata/libata-sff.c |   38 ++++++++++++++++++++++++++++----------
>   drivers/ata/sata_mv.c    |    2 +-
>   include/linux/libata.h   |    3 ++-
>   3 files changed, 31 insertions(+), 12 deletions(-)

FWIW, the normal standard for revised patches is to include a short 
changelog following the "---", but preceding the patch itself. 
Something like:

---------------------SNIP-----------------------
Not all libata-sff is PMP compliant. Code for native BMDMA controller
does not take in accound PMP.

Tested on Marvell 7042 and Sil7526.

Signed-off-by: Gwendal Grignou <gwendal@google.com>
---
v3: cleanups, add WARN_ON() etc
v2: ata_sff_queue_pio_task takes a qc etc

  drivers/ata/libata-sff.c |   38 ++++++++++++++++++++++++++++----------
  drivers/ata/sata_mv.c    |    2 +-
  include/linux/libata.h   |    3 ++-
  3 files changed, 31 insertions(+), 12 deletions(-)
---------------------SNIP-----------------------



I'll queue this up along with the other libata fixes tonight (unless 
there are further revisions of course:))

	Jeff



  reply	other threads:[~2010-08-31 23:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-21 18:52 possible esata regression in 2.6.35 Nicolas Jungers
2010-08-21 19:13 ` Mark Lord
2010-08-21 19:59   ` Nicolas Jungers
2010-08-22 19:54 ` Jeff Garzik
2010-08-22 19:57   ` Jeff Garzik
2010-08-27  8:19     ` Gwendal Grignou
     [not found]       ` <AANLkTi=deJbndavPJmFzEoy6kZQX8LdoAdE+QQN5if0=@mail.gmail.com>
2010-08-27 22:56         ` Gwendal Grignou
2010-08-29  0:31           ` [PATCH] libata-sff: Reenable Port Multiplier after libata-sff remodeling Gwendal Grignou
2010-08-29  9:05             ` Tejun Heo
2010-08-30 17:17               ` Gwendal Grignou
2010-08-31  8:04                 ` Tejun Heo
2010-08-31 23:17                   ` Gwendal Grignou
2010-09-01  8:21                     ` Tejun Heo
2010-08-31 23:20                   ` Gwendal Grignou
2010-08-31 23:32                     ` Jeff Garzik [this message]
2010-09-01  5:57                       ` Gwendal Grignou
2010-08-30 17:19               ` Gwendal Grignou
2010-08-29  0:40           ` possible esata regression in 2.6.35 Gwendal Grignou
2010-08-25 19:00 ` Maciej Rutecki
  -- strict thread matches above, loose matches on Subject: below --
2010-09-01 16:33 [PATCH] libata-sff: Reenable Port Multiplier after libata-sff remodeling Kalra Ashish-B00888

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C7D9108.5010506@garzik.org \
    --to=jeff@garzik.org \
    --cc=gwendal@google.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=nicolas@jungers.net \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.