All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] cfi_flash: Add weak default for cfi_flash_bank_addr()
Date: Wed, 01 Sep 2010 13:36:25 +0400	[thread overview]
Message-ID: <4C7E1E99.201@mvista.com> (raw)
In-Reply-To: <1283254435-11783-1-git-send-email-sr@denx.de>

Hello.

Stefan Roese wrote:

> cfi_flash_bank_addr(int bank_nr) returns the base addresses of the
> requested bank. Introducing this weak default enables boards to override
> this functions with a board specific version when required.

> This feature will be used in the lwmon5 board update, supporting runtime
> detection of 2 board revisions with different flash layouts.

> Signed-off-by: Stefan Roese <sr@denx.de>
[...]
> diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
> index b4a09dc..f10e09e 100644
> --- a/drivers/mtd/cfi_flash.c
> +++ b/drivers/mtd/cfi_flash.c
[...]
> @@ -2021,14 +2028,12 @@ unsigned long flash_init (void)
>  	getenv_f("unlock", s, sizeof(s));
>  #endif
>  
> -#define BANK_BASE(i)	(((phys_addr_t [CFI_MAX_FLASH_BANKS])CONFIG_SYS_FLASH_BANKS_LIST)[i])
> -
>  	/* Init: no FLASHes known */
>  	for (i = 0; i < CONFIG_SYS_MAX_FLASH_BANKS; ++i) {
>  		flash_info[i].flash_id = FLASH_UNKNOWN;
>  
> -		if (!flash_detect_legacy (BANK_BASE(i), i))
> -			flash_get_size (BANK_BASE(i), i);
> +		if (!flash_detect_legacy (cfi_flash_bank_addr(i), i))
> +			flash_get_size (cfi_flash_bank_addr(i), i);

    Could remove the sopaces before parens to improve the coding style, while 
at it...

WBR, Sergei

      reply	other threads:[~2010-09-01  9:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-31 11:33 [U-Boot] [PATCH 2/4] cfi_flash: Add weak default for cfi_flash_bank_addr() Stefan Roese
2010-09-01  9:36 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C7E1E99.201@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.