From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 03/11] __ofono_call_barring_is_busy internal api for STK-Send USSD
Date: Wed, 01 Sep 2010 10:22:25 -0500 [thread overview]
Message-ID: <4C7E6FB1.1000603@gmail.com> (raw)
In-Reply-To: <1283338836-13572-3-git-send-email-jeevaka.badrappan@elektrobit.com>
[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]
Hi Jeevaka,
On 09/01/2010 06:00 AM, Jeevaka Badrappan wrote:
> ---
> src/call-barring.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/src/call-barring.c b/src/call-barring.c
> index 7607f3f..b58499a 100644
> --- a/src/call-barring.c
> +++ b/src/call-barring.c
> @@ -580,6 +580,11 @@ static void cb_unregister_ss_controls(struct ofono_call_barring *cb)
> __ofono_ussd_passwd_unregister(cb->ussd, "353");
> }
>
> +gboolean __ofono_call_barring_is_busy( struct ofono_call_barring *cb)
> +{
> + return cb->pending ? TRUE: FALSE;
> +}
> +
> static inline void cb_append_property(struct ofono_call_barring *cb,
> DBusMessageIter *dict, int start,
> int end, int cls, const char *property)
The rule of thumb for patch submissions is to:
- Make sure all related chunks are together in one patch
- Chunks are only related to the particular change being described
- Unless impossible / extremely hard, the code should compile after each
individual patch.
In this case, please merge the chunks from patch #8 related to call
barring into this patch.
Regards,
-Denis
next prev parent reply other threads:[~2010-09-01 15:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 11:00 [PATCH 01/11] added Send USSD string maximum length Jeevaka Badrappan
2010-09-01 11:00 ` [PATCH 02/11] Changes done as per the changed driver API Jeevaka Badrappan
2010-09-01 12:49 ` Pekka Pessi
2010-09-01 15:12 ` Andrzej Zaborowski
2010-09-02 8:00 ` Jeevaka.Badrappan
2010-09-01 11:00 ` [PATCH 03/11] __ofono_call_barring_is_busy internal api for STK-Send USSD Jeevaka Badrappan
2010-09-01 15:22 ` Denis Kenzior [this message]
2010-09-01 11:00 ` [PATCH 04/11] __ofono_call_forwarding_is_busy " Jeevaka Badrappan
2010-09-01 15:23 ` Denis Kenzior
2010-09-01 11:00 ` [PATCH 05/11] __ofono_call_settings_is_busy " Jeevaka Badrappan
2010-09-01 11:00 ` [PATCH 06/11] Send USSD proactive command handling Jeevaka Badrappan
2010-09-01 15:35 ` Denis Kenzior
2010-09-01 16:43 ` andrzej zaborowski
2010-09-01 11:00 ` [PATCH 07/11] added stk_response_text_string for USSD result Jeevaka Badrappan
2010-09-01 15:33 ` Denis Kenzior
2010-09-02 0:22 ` andrzej zaborowski
2010-09-02 8:05 ` Jeevaka.Badrappan
2010-09-01 11:00 ` [PATCH 08/11] STK:Send USSD internal apis Jeevaka Badrappan
2010-09-01 11:00 ` [PATCH 09/11] Driver API changed to accept DCS and any format string Jeevaka Badrappan
2010-09-01 15:37 ` Denis Kenzior
2010-09-01 11:00 ` [PATCH 10/11] Changes done as per the changed driver API Jeevaka Badrappan
2010-09-01 11:00 ` [PATCH 11/11] __ofono_ussd_initiate internal api for STK-Send USSD Jeevaka Badrappan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7E6FB1.1000603@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.