From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50252 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Or9pU-0005ox-Nw for qemu-devel@nongnu.org; Thu, 02 Sep 2010 09:27:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Or9p3-0007UO-Uq for qemu-devel@nongnu.org; Thu, 02 Sep 2010 09:27:23 -0400 Received: from mail-qy0-f180.google.com ([209.85.216.180]:47253) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Or9p3-0007UH-Ou for qemu-devel@nongnu.org; Thu, 02 Sep 2010 09:27:21 -0400 Received: by qyk31 with SMTP id 31so618653qyk.4 for ; Thu, 02 Sep 2010 06:27:21 -0700 (PDT) Message-ID: <4C7FA636.7030208@codemonkey.ws> Date: Thu, 02 Sep 2010 08:27:18 -0500 From: Anthony Liguori MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/6 v3] introduce qbus reset callback and pci bus reset clean up List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: gleb@redhat.com, glommer@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, alex.williamson@redhat.com, avi@redhat.com, pbonzini@redhat.com On 09/02/2010 04:25 AM, Isaku Yamahata wrote: > I recreated the patch series based on your qbus walker of > git://repo.or.cz/qemu/aliguori.git > > Anthony, can you please review the first three patches and merge them > if okay? > They look really nice, I'll merge them into my branch. > BTW what's the merge plan of the repo? Any chance to merge the walker part > first? > I'm still working on vmsd refactoring but I can split out an initial series that doesn't contain that and includes your reset changes. Regards, Anthony LIguori > Patch description: > Introduce bus reset callback at qbus layer and clean up pci bus reset > by utilizing it. At last implement pci secondary bus reset which is > my motivation. > But I suppose scsi bus and ide bus also can take advantage of > this patch series. > > Changes v2 -> v3: > - rebased to Anthony's qdev clean up tree. > - utilize qbus walker. > > Changes v1 -> v2: > - addressed personal feed back from Gerd. > - reset signal are triggered by bus and propagated down into device. > - Only 5/8 is modified. Other patches remains same. > > Isaku Yamahata (6): > qdev: Make qbus_walk_children() call busfn for root bus. > qdev: introduce reset call back for qbus level. > qdev: introduce a helper function which triggers reset from a given > device. > pci: make pci reset use qdev reset frame work. > pci: teach pci devices that have reset callback how to reset common > registers. > pci bridge: implement secondary bus reset. > > hw/e1000.c | 1 + > hw/lsi53c895a.c | 2 + > hw/pci.c | 45 +++++++++++++++++++++++++++++++++---- > hw/pci.h | 2 + > hw/pcnet.c | 1 + > hw/qdev-core.h | 6 +++++ > hw/qdev.c | 66 ++++++++++++++++++++++++++++++++++++------------------ > hw/rtl8139.c | 2 + > hw/virtio-pci.c | 1 + > 9 files changed, 99 insertions(+), 27 deletions(-) > >