From: Avi Kivity <avi@redhat.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@kernel.org
Subject: Re: [PATCH 2/3] KVM: SVM: Restore correct registers after sel_cr0 intercept emulation
Date: Thu, 02 Sep 2010 19:02:02 +0300 [thread overview]
Message-ID: <4C7FCA7A.1020809@redhat.com> (raw)
In-Reply-To: <1283441387-7378-3-git-send-email-joerg.roedel@amd.com>
On 09/02/2010 06:29 PM, Joerg Roedel wrote:
> This patch implements restoring of the correct rip, rsp, and
> rax after the svm emulation in KVM injected a selective_cr0
> write intercept into the guest hypervisor. The problem was
> that the vmexit is emulated in the instruction emulation
> which later commits the registers right after the write-cr0
> instruction. So the l1 guest will continue to run with the
> l2 rip, rsp and rax resulting in unpredictable behavior.
>
Please post a unit test for this.
> This patch is not the final word, it is just an easy patch
> to fix the issue. The real fix will be done when the
> instruction emulator is made aware of nested virtualization.
> Until this is done this patch fixes the issue and provides
> an easy way to fix this in -stable too.
I agree. We can probably use X86EMUL_PROPAGATE_FAULT to abort
emulation, but looking at the code, it will take some refactoring.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-09-02 16:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 15:29 [PATCH 0/3] KVM fixes and cleanups Joerg Roedel
2010-09-02 15:29 ` [PATCH 1/3] KVM: MMU: Fix 32 bit legacy paging with NPT Joerg Roedel
2010-09-02 15:56 ` Avi Kivity
2010-09-02 16:32 ` Roedel, Joerg
2010-09-02 15:29 ` [PATCH 2/3] KVM: SVM: Restore correct registers after sel_cr0 intercept emulation Joerg Roedel
2010-09-02 16:02 ` Avi Kivity [this message]
2010-09-02 16:29 ` Roedel, Joerg
2010-09-05 7:09 ` Avi Kivity
2010-09-02 15:29 ` [PATCH 3/3] KVM: SVM: Clean up rip handling in vmrun emulation Joerg Roedel
2010-09-03 12:21 ` Roedel, Joerg
2010-09-03 21:29 ` Alexander Graf
2010-09-04 19:32 ` Joerg Roedel
2010-09-06 18:26 ` [PATCH 0/3] KVM fixes and cleanups Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7FCA7A.1020809@redhat.com \
--to=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.