From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1OrHae-0004gY-SB for mharc-grub-devel@gnu.org; Thu, 02 Sep 2010 17:45:00 -0400 Received: from [140.186.70.92] (port=57962 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OrHaY-0004ZO-5q for grub-devel@gnu.org; Thu, 02 Sep 2010 17:44:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OrHaW-00038e-Kz for grub-devel@gnu.org; Thu, 02 Sep 2010 17:44:54 -0400 Received: from mail-fx0-f41.google.com ([209.85.161.41]:49672) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OrHaW-00038W-FK for grub-devel@gnu.org; Thu, 02 Sep 2010 17:44:52 -0400 Received: by fxm3 with SMTP id 3so768836fxm.0 for ; Thu, 02 Sep 2010 14:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=ecIwjDBdlpeHDZ+yQhGe1+2Xhxj3J192/zRilYssm90=; b=BSqNQDmhDXOU1gUU/e16NIVfzhwY85+59pfG43aOATzydkHuxReiBBjHXk1tHhJjJc 4OokU8mCBfb3kYO4sXajAiVaMJk/8qm1aSydQyl+EsGHSQ+m5/R3hQEDVE3J8O0u4aIc /1y1sOpF/Zwq9QhZFIIa+SwEDeDuHnnRXf7EI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=nV5QYbYuKqfKoLVDx4zhibu6uXCBiJDgnHZDw31oPEEMhHoR3JCvSqfBsXwFEiiHle g8TSc1B1sNjhn3LL9NFqw4X3v5S32pLWATXXUtMEu2yEyQ6l3OZcnprmXTKPch9j26oN w3Pk0SKvBSDqcFy1Qbu2uiNAtS6qG8TmKDTKU= Received: by 10.223.123.145 with SMTP id p17mr9261614far.90.1283463891412; Thu, 02 Sep 2010 14:44:51 -0700 (PDT) Received: from debian.bg45.phnet (62-156.62-81.cust.bluewin.ch [81.62.156.62]) by mx.google.com with ESMTPS id 14sm517749fav.2.2010.09.02.14.44.48 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 02 Sep 2010 14:44:50 -0700 (PDT) Message-ID: <4C801AC9.9050805@gmail.com> Date: Thu, 02 Sep 2010 23:44:41 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100805 Icedove/3.0.6 MIME-Version: 1.0 To: grub-devel@gnu.org References: <20100901124021.8378.90579.stgit@colinux.localdomain> In-Reply-To: <20100901124021.8378.90579.stgit@colinux.localdomain> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigEA59AD7064E8EEDB5FAC20B0" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Bash completion script for util commands X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Sep 2010 21:44:59 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigEA59AD7064E8EEDB5FAC20B0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/01/2010 02:40 PM, Yves Blusseau wrote: > * Makefile.am: Add util/bash-completion.d directory > * configure.ac: Likewise. > * util/bash-completion.d/Makefile.am: New file. > * util/bash-completion.d/grub-completion.bash.in: Likewise. > --- > ChangeLog.completion.bash | 6=20 > Makefile.am | 2=20 > configure.ac | 1=20 > util/bash-completion.d/Makefile.am | 15 + > util/bash-completion.d/grub-completion.bash.in | 450 ++++++++++++++++= ++++++++ > 5 files changed, 473 insertions(+), 1 deletions(-) > create mode 100644 ChangeLog.completion.bash > create mode 100644 util/bash-completion.d/Makefile.am > create mode 100644 util/bash-completion.d/grub-completion.bash.in > =20 > bash-completion.patch > > > +DISTCLEANFILES =3D *~ > =20 We don't add *~ in other Makefile.am. If this should be changed it should be on the level of whole GRUB > +__@grubname@_dir() { > =20 Functionnames aren't transformed > + root_dir=3D${root_dir-/} > =20 but dirnames are > + if [[ -d "$root_dir/boot" ]]; then > + boot_dir=3D"$root_dir/boot" > =20 likewise > + else > + boot_dir=3D"$root_dir" > =20 > + fi > + echo "${boot_dir%/}/grub" > =20 likewise These errors repeat themselves many times and make the patch more difficult to read. Once they are fixed I'll have another look for more comments. --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigEA59AD7064E8EEDB5FAC20B0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAkyAGskACgkQNak7dOguQglUVgD+Nz3xXe3WicH3uqZ/AvgmcCjx ePhJ+EDinmf3mlN7LM4A/iQ31a1fV0TprwR0if6P82xRPvBbPzQhvWnH5ZcQItUu =OHyO -----END PGP SIGNATURE----- --------------enigEA59AD7064E8EEDB5FAC20B0--