Re: [PATCH 1/1] mount: RDMA processing in the mount command is broken

[Steve Dickson <SteveD@redhat.com>]

On 09/02/2010 04:35 PM, Chuck Lever wrote:
> 
> On Sep 2, 2010, at 4:00 PM, Steve Dickson wrote:
> 
>> The mounting code that process RMDA mounts is broken in a few places
>>
>> First with '-o proto=rdma' was broken because nfs_get_proto()
>> did not how to convert a netid of 'rdma' in to a AF_INET
>> address family.
>>
>> Secondly, '-o rdma' was broken because po_get() was being using
>> to detect the existence of 'rdma' in the options. With '-o rdma'
>> there is no value associated with that option so po_get()
>> was always return NULL.
> 
> Looking at nfs(5), "rdma" as a stand-alone option isn't documented.  Only "proto=rdma" appears to be mentioned.  Thus I would argue that this is already behaving correctly.
> 
> Are you proposing to add support for "-o rdma" ?  If so what would that mean?
See Documentation/filesystems/nfs/nfs-rdma.txt

I see no problem in handing this same why we handle 'udp' and 'tcp'

steved.