All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: Vasiliy G Tolstov <v.tolstov@selfip.ru>,
	"Xen-Devel (xen-devel@lists.xensource.com)"
	<xen-devel@lists.xensource.com>,
	tmem-devel@oss.oracle.com, Kurt Hackel <kurt.hackel@oracle.com>,
	Jan Beulich <JBeulich@novell.com>,
	Keir Fraser <keir.fraser@eu.citrix.com>,
	stephen.spector@citrix.com, Chris Mason <chris.mason@oracle.com>
Subject: Re: [RFC] tmem ABI change... backwards compatibility unnecessary?
Date: Thu, 02 Sep 2010 16:39:08 -0700	[thread overview]
Message-ID: <4C80359C.5050002@goop.org> (raw)
In-Reply-To: <c84f89c9-34ae-4599-9f1e-90ed84dfa837@default>

 On 09/02/2010 04:19 PM, Dan Magenheimer wrote:
> OK, I will submit a patch tomorrow with the following characteristics:
>
> v0 (current) hypervisor + v0 guest: succeeds
> v1 (patched) hypervisor + v1 guest: succeeds
> v0 (current) hypervisor + v1 guest: fails
> v1 (patched) hypervisor + v0 guest: fails
>
> where fails is an xm dmesg message that says "unsupported
> spec version" when the guest attempts to create a pool.
> And pool creation failure ensures that all further tmem
> operations also fail (indeed never even result in a
> hypercall for most tmem-enabled kernels).
>
> Thank goodness ABI versioning was built into tmem from
> the beginning!

Hm, I'm not really a big fan of having a single "ABI version".  It
always seems better to have individual calls which can be
augmented/replaced by new calls, and/or have capability flags to extend
the ABI.  Versions mean you end up being stuck doing updates in a very
coarse-grained way, and the long-term support gets very onerous.
(Microsoft ABIs are a good antipattern to avoid, especially DirectX.)

    J

  reply	other threads:[~2010-09-02 23:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-01 14:36 [RFC] tmem ABI change... backwards compatibility unnecessary? Dan Magenheimer
2010-09-01 14:44 ` Vasiliy G Tolstov
2010-09-01 15:37   ` Dan Magenheimer
2010-09-01 15:04 ` Jan Beulich
2010-09-02 23:19   ` Dan Magenheimer
2010-09-02 23:39     ` Jeremy Fitzhardinge [this message]
2010-09-03 14:47       ` Dan Magenheimer
2010-09-01 16:46 ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C80359C.5050002@goop.org \
    --to=jeremy@goop.org \
    --cc=JBeulich@novell.com \
    --cc=chris.mason@oracle.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=kurt.hackel@oracle.com \
    --cc=stephen.spector@citrix.com \
    --cc=tmem-devel@oss.oracle.com \
    --cc=v.tolstov@selfip.ru \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.