Re: [PATCH V2] OMAP: DSS2: don't power off a panel twice

["stanley.miao" <stanley.miao@windriver.com>]

Hi, Tomi,

Tomi Valkeinen wrote:
> <snip>
>
> Otherwise this looks fine, except that panel-taal.c does not need
> modifications, as it already handles this case.
>   

I will send a V3 to remove the panel-taal.c part.

> Also, at some point I (or somebody else =) should think how to do proper
> locking for the panel drivers. Currently it's rather broken, and, for
> example, enabling and disabling a panel at the same time will cause
> problems. Except for panel-taal, which uses its own lock.
>   

First, I don't think there is any occasion where you need to enable and 
disable a panel at the same time.
If so, what kind of result do you want ? enabled or disabled ?

Second, now the dssdev->state can do the lock job properly. It can 
ensure only one function can run if both disable()
and enable are called at the same time.

Stanley.

>  Tomi
>
>
>
>