Re: hibernation hangs with ATA errors (lockup_detector bug)

[Jiri Slaby <jirislaby@gmail.com>]

On 06/06/2010 08:22 AM, Jiri Slaby wrote:
> On 06/02/2010 08:44 PM, Don Zickus wrote:
>> --- a/kernel/watchdog.c
>> +++ b/kernel/watchdog.c
>> @@ -550,8 +550,7 @@ cpu_callback(struct notifier_block *nfb, unsigned long action, void *hcpu)
>>  		break;
>>  	case CPU_ONLINE:
>>  	case CPU_ONLINE_FROZEN:
>> -		if (watchdog_enable(hotcpu))
>> -			return NOTIFY_BAD;
>> +		watchdog_enable(hotcpu)
> 
> This fixes the problem indeed.

Hi, was this fixed somehow? I still use this hunk and don't know if it
is needed:
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -524,7 +524,7 @@ cpu_callback(struct notifier_block *nfb, unsigned
long action, void *hcpu)
                break;
        case CPU_ONLINE:
        case CPU_ONLINE_FROZEN:
-               err = watchdog_enable(hotcpu);
+               watchdog_enable(hotcpu);
                break;
 #ifdef CONFIG_HOTPLUG_CPU
        case CPU_UP_CANCELED:

thanks,
-- 
js