From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/4] Enable alphabets in smsutils
Date: Fri, 03 Sep 2010 09:05:20 -0500 [thread overview]
Message-ID: <4C8100A0.4010804@gmail.com> (raw)
In-Reply-To: <1283516151.25646.2.camel@tucson.research.nokia.com>
[-- Attachment #1: Type: text/plain, Size: 664 bytes --]
Hi Aki,
On 09/03/2010 07:15 AM, Aki Niemi wrote:
> On Thu, 2010-09-02 at 18:55 +0200, ext Denis Kenzior wrote:
>>> - if (offset != 0)
>>> - template.submit.udhi = FALSE;
>>> -
>>
>> This part doesn't look right. The check should actually set udhi to
>> TRUE, since we can be issuing a return in the next if statement...
>
> That's why it's removed. This was doing nothing before, as offset at
> this point was always zero, and the template had anyway been memset to
> zero.
>
I see what you're doing now. I'd rather you left out setting udhi in
the dialect switch/case labels and changed this line to set UDHI to TRUE.
Regards,
-Denis
next prev parent reply other threads:[~2010-09-03 14:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 7:52 [PATCH 1/4] Add so called reduced charset support to SMS Aki Niemi
2010-09-02 7:52 ` [PATCH 2/4] Enable alphabets in smsutils Aki Niemi
2010-09-02 16:55 ` Denis Kenzior
2010-09-03 12:15 ` Aki Niemi
2010-09-03 14:05 ` Denis Kenzior [this message]
2010-09-03 14:12 ` Aki Niemi
2010-09-03 14:40 ` Pekka Pessi
2010-09-03 15:08 ` Denis Kenzior
2010-09-03 17:09 ` Aki Niemi
2010-09-02 7:52 ` [PATCH 3/4] Add alphabet support to SMS atom Aki Niemi
2010-09-02 17:00 ` Denis Kenzior
2010-09-02 7:52 ` [PATCH 4/4] Add documentation for the Alphabet property Aki Niemi
2010-09-02 17:01 ` Denis Kenzior
2010-09-02 18:19 ` Marcel Holtmann
2010-09-02 19:08 ` Aki Niemi
2010-09-02 16:43 ` [PATCH 1/4] Add so called reduced charset support to SMS Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8100A0.4010804@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.