Re: [advices] patch for dynamically changing vif rate via proc file

[Jeremy Fitzhardinge <jeremy@goop.org>]

 On 09/02/2010 03:03 AM, ahmed amamou wrote:
> Hi Jermey and Chris,
> Sorry to bother you with this but as Maintainers  of XEN HYPERVISOR
> INTERFACE ,i wanted to ask you something
>
> I trying to make a patch that would allow me to dynamically change vif
> rate from a /proc file
> change written in proc file will be saved and value of
> netif->credit_usec and netif->credit_bytes will be assigned on the
> next tx_credit_exceeded check
> the patch mat be ready before the end of the day if you want i'll send
> you it as soon as i finish
>
> i just wanted to ask you if it was a good way to change vif rate from
> a proc file,as a beginner i don't really know to much of best
> practises in modules programming

/proc is definitely the wrong API for this.

For this kind of thing, its probably better to either use netlink, or
xenbus (xenstore) to keep this kind of per-interface parameter tuning.

But it isn't even clear that doing it at the device level is correct
anyway.  If the guest wants to control its own network traffic, or if
dom0 wants to control the guest traffic, there are many generic
mechanisms for doing traffic shaping.

What are you trying to achieve?

Thanks,
    J