From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] NET: add ENC28J60 driver using SPI framework
Date: Fri, 03 Sep 2010 23:23:43 +0200 [thread overview]
Message-ID: <4C81675F.3030006@emk-elektronik.de> (raw)
In-Reply-To: <201009031703.56678.vapier@gentoo.org>
On 03.09.2010 23:03, Mike Frysinger wrote:
>> not sure, however, if calling spi_setup_slave() is ok at this point.
>
> i believe the func should only doing validation on the arguments. it shouldnt
> need to talk to any actual hardware. maybe this needs codifying in the API
> documentation.
In atmel_spi.c it sets up the csr[indexed by cs=0..3] register with clock,
phase and polarity.
That's harmless, but might need some rethinking there.
Reinhard
next prev parent reply other threads:[~2010-09-03 21:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 12:47 [U-Boot] [PATCH] NET: add ENC28J60 driver using SPI framework Reinhard Meyer
2010-08-26 3:55 ` Mike Frysinger
2010-08-26 6:19 ` Reinhard Meyer
2010-08-26 6:32 ` Mike Frysinger
2010-08-26 6:41 ` Reinhard Meyer
2010-08-26 7:11 ` Mike Frysinger
2010-09-03 17:50 ` Reinhard Meyer
2010-09-03 19:51 ` Mike Frysinger
2010-09-03 20:31 ` Reinhard Meyer
2010-09-03 21:03 ` Mike Frysinger
2010-09-03 21:23 ` Reinhard Meyer [this message]
2010-09-03 22:14 ` Mike Frysinger
2010-09-04 3:25 ` Reinhard Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C81675F.3030006@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.